Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback fixes #58

Merged
merged 27 commits into from
Dec 5, 2023
Merged

Feedback fixes #58

merged 27 commits into from
Dec 5, 2023

Conversation

C-Achard
Copy link
Collaborator

@C-Achard C-Achard commented Nov 15, 2023

Aims to iron out some QoL issues and bugs based on user feedback.

NOTE :


@C-Achard C-Achard added enhancement New feature or request fix Something needs to be or has been fixed labels Nov 15, 2023
@C-Achard C-Achard self-assigned this Nov 15, 2023
@C-Achard C-Achard changed the base branch from main to cy/training November 15, 2023 16:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (cy/training@dfefe03). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             cy/training      #58   +/-   ##
==============================================
  Coverage               ?   80.87%           
==============================================
  Files                  ?       46           
  Lines                  ?     5914           
  Branches               ?        0           
==============================================
  Hits                   ?     4783           
  Misses                 ?     1131           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@C-Achard C-Achard mentioned this pull request Nov 18, 2023
@C-Achard C-Achard mentioned this pull request Nov 21, 2023
@C-Achard C-Achard requested review from CYHSM and MMathisLab November 21, 2023 15:39
@C-Achard C-Achard marked this pull request as ready for review November 21, 2023 15:39
C-Achard and others added 10 commits November 22, 2023 14:10
* WIP add artifact removal

* Add utils and inference worker artifact removal

* Fix issue with layer type in utils

* Add better pbar and windowed artifact rem

* Refactor results name to be more explicit

* Add working pbar to Inference log

* Reduce requirements

* Fix spheric. test and import checking

* Update worker_training.py

* Update worker_training.py
* Remove itk temp

* Update napari_cellseg3d_m1.yml

* Update napari_cellseg3d_m1.yml

* Remove duplicate imagecodecs

* Update napari_cellseg3d_m1.yml

* Remove imagecodecs TEMP

* Fixing tests on M1

* Remove erroneous path in test

* Update test_utils.py

* Update test_utils.py

* Changed  python to 3.9 for ITK

* Docs update

* Minor docs tweaks

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* README and docs update

* Labels stats notebook update

* mv full plot to better name

* Fix attr error in inference
@C-Achard C-Achard merged commit 80feb8f into cy/training Dec 5, 2023
@C-Achard C-Achard deleted the cy/feedback-fixes branch December 14, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix Something needs to be or has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.tif files restricted
2 participants