Designer: Fix parent fill color handling #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
awentzel,
KingOfTac and
nicholasrice
as code owners
nicholasrice
approved these changes
Oct 17, 2024
bheston
force-pushed
the
users/bheston/aui-new-style-properties
branch
from
c2686d4 to
36460a2
Compare
Base automatically changed from
users/bheston/aui-new-style-properties
to
main
October 18, 2024 02:31
bheston
force-pushed
the
users/bheston/aui-fix-parent-fill-color
branch
from
3e04282 to
01e1917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
I think I've finally resolved the issue where colors were being calculated incorrectly until you unselected and reselected a layer.
Cleaned up the handling of the effective fill color when you might have layers without a fill.
The key fix is in clearing the design token values in the shadow hierarchy at the right place so it's not latching old colors.
Test Plan
Tested in Figma Designer.
Checklist
General