fix(DOGE/DASH): transfering funds doesn't work after bitcoinjs-lib upgrade
#552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RealGoodProgrammer
temporarily deployed
to
testing
GitHub Actions
Inactive
|
Deployed to https://msg-adamant-pr-552.surge.sh 🚀 |
bludnic
requested changes
Nov 6, 2023
RealGoodProgrammer
temporarily deployed
to
testing
GitHub Actions
Inactive
bludnic
requested changes
Nov 6, 2023
martiliones
requested changes
Nov 6, 2023
There was a problem hiding this comment.
What is the bug? It's not clear based on your commits nor PR description. Write actual description of the changes in the commits. Additionally, I highly recommend you to familiarize yourself with conventional commits, that's what we use across the projects (this repository doesn't include commitlint for some reason though).
Also use more descriptive variable names, here are some suggestions:
amt->unspentAmountinputs->inputCountchange->differencetxb->psbt
bludnic
changed the title
bitcoinjs-lib upgrade
martiliones
changed the title
bitcoinjs-lib upgradebitcoinjs-lib upgrade
RealGoodProgrammer
temporarily deployed
to
testing
GitHub Actions
Inactive
RealGoodProgrammer
temporarily deployed
to
testing
GitHub Actions
Inactive
martiliones
requested changes
Nov 8, 2023
martiliones
reviewed
Nov 8, 2023
RealGoodProgrammer
temporarily deployed
to
testing
GitHub Actions
Inactive
bludnic
approved these changes
Nov 8, 2023
martiliones
approved these changes
Nov 8, 2023
|
Successfully tore down https://msg-adamant-pr-552.surge.sh 🥲 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.