Skip to content

create VcfFileReader based on RecordReader #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Conversation

ChristinaXu2017
Copy link
Contributor

@ChristinaXu2017 ChristinaXu2017 commented Feb 12, 2021

Description

Created a new VcfFileReader based on RecordReader which is created on pull request #209. This reader will replace org.qcmg.vcf.VCFFileReader. The related unit test is created.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

unit test and regression test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@holmeso holmeso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ChristinaXu2017 ChristinaXu2017 merged commit ca65b51 into master Feb 15, 2021
@ChristinaXu2017 ChristinaXu2017 deleted the newVcfReader branch February 17, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants