Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qsnp qio #230

Merged
merged 6 commits into from
Feb 1, 2021
Merged

Qsnp qio #230

merged 6 commits into from
Feb 1, 2021

Conversation

ChristinaXu2017
Copy link
Contributor

@ChristinaXu2017 ChristinaXu2017 commented Jan 31, 2021

Description

Update qSnp:

  • delete commented code in qsnp.
  • org.qcmg.tab.* is replacing by qio.record.* which is created on pull request create universal reader and writer #209
  • move org.qcmg.pileup.QSnpRecord from qio to org.qcmg.common.model.QsnpRecord. Here QsnpRecord is similar to other qcommon::model classes, such as QSnpGATKRecord, BLATRecord, which used by multi projects but not only belong to IOs.

here we should also consider issue #231. We are not sure whether we should delete both QSnpRecord and QSnpGATKRecord on the next pull request.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests and regression test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@holmeso holmeso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ChristinaXu2017 ChristinaXu2017 merged commit 9d45e24 into master Feb 1, 2021
@ChristinaXu2017 ChristinaXu2017 deleted the qsnp_qio branch February 2, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants