Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading qio #227

Closed
wants to merge 77 commits into from
Closed

upgrading qio #227

wants to merge 77 commits into from

Conversation

ChristinaXu2017
Copy link
Contributor

@ChristinaXu2017 ChristinaXu2017 commented Jan 29, 2021

Description

In this pull request, we update qio project and fixe #196, #197, #198, #213, #217, #218, #219.

  1. Created new packages, based on the new "org.qcmg.qio.record" package; These new packages named with "qio" string, it will be easy for the user to identify the package belongs.
  • org.qcmg.qio.record replace org.qcmg.string, org.qcmg.tab, org.qcmg.pileup.pileup*, org.qcmg.record
  • org.qcmg.qio.gff replace org.qcmg.gff
  • org.qcmg.qio.fasta replace org.qcmg.fasta
  • org.qcmg.qio.gff3 replace org.qcmg.gff3
  • org.qcmg.qio.illumina replace org.qcmg.illumina
  • org.qcmg.qio.ma replace org.qcmg.ma
  1. Deprecated unused packages:
  • org.qcmg.reader
  • org.qcmg.primerdesignsummary
  • org.qcmg.maf
  • org.qcmg.consensuscalls,
  • org.qcmg.bed,
  • org.qcmg.genesymbol,
  • org.qcmg.primeroutput,
  • org.qcmg.simple,
  • org.qcmg.primerinput,
  • org.qcmg.Utils
  1. Rename packages by adding "qmule" string ,which are only used by qmule project. Here qmule is a collection of temporary tools, they are not well maintained:
  • org.qcmg.qmule.pileup;
  • org.qcmg.qmule.chrconv;
  • org.qcmg.qmule.record;
  • org.qcmg.qmule.tab;
  • org.qcmg.qmule.germlinedb;
  • org.qcmg.qmule.gff3;
  • org.qcmg.qmule.dbsnp;
  • org.qcmg.qmule.exception;
  1. qio is widely applied in our most adamajava project, the above updates are also applied to the below projects:
  • qsv
  • qsv
  • q3tiledaligner
  • qsignature
  • qsnp
  • qprofiler
  • qcoverage
  • q3panel
  • qmaftools
  • qbamannotate
  • qpileup
  • qmule

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The unit test is updated; whole adamajava gradle build is run; TC regression tests are created which test the output from qsv, q3tiledaligner, qsignature, qsnp, q3indel , q3vcftools, qannotate, qprofiler2, qprofiler, qvisualise, qbammerge, qcoverage. However, TC regression tests don't cover q3panel, qmaftools, qbamannotate, qpileup, qmule; these project maybe dated and plan to deprecate.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@holmeso
Copy link
Contributor

holmeso commented Jan 29, 2021

This PR is referencing 7 issues.
Could you please raise seperate PR's for each issue to make it easier to review - thanks!

@ChristinaXu2017
Copy link
Contributor Author

Let me try to split them into multi pull requests.

@ChristinaXu2017 ChristinaXu2017 deleted the Bdevelop.qio branch August 31, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants