Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to deprecate qSNP related QSnpGATKRecord and QSnpRecord #231

Open
ChristinaXu2017 opened this issue Jan 31, 2021 · 1 comment
Open

to deprecate qSNP related QSnpGATKRecord and QSnpRecord #231

ChristinaXu2017 opened this issue Jan 31, 2021 · 1 comment

Comments

@ChristinaXu2017
Copy link
Contributor

Is your feature request related to a problem? Please describe.
QSnpGATKRecord and QSnpRecord are marked as deprecated for a long time, however, we can't really remove them since they are used by other projects unless we remove the below classes:

  1. QSnpRecord is required by qsnp::PileupPipeline and qsnp::MuTectPipeline requires. This two pipeline seems old and no longer used by recent SNP calls.
  2. QSnpGATKRecord is required by qsnp::util::QJumperWorker, which is also only required by qsnp::PileupPipeline.
  3. qsnp::util::BAMPileupUtil calls both QSnpGATKRecord and QSnpRecord, but this class is not used by qSnp and other projects
  4. qnp::TorrentPipeline is an old method too, even it calls neither QSnpGATKRecord nor QSnpRecord.

Describe the solution you'd like
QSnpGATKRecord and QSnpRecord should be deleted only we decide to remove qsnp::PileupPipeline, qsnp::MuTectPipeline, qnp::TorrentPipeline, qsnp::util::BAMPileupUtil and qsnp::util::QJumperWorker

Additional context
leave for open discussion

@ChristinaXu2017 ChristinaXu2017 mentioned this issue Jan 31, 2021
11 tasks
@ChristinaXu2017
Copy link
Contributor Author

After a discussion, there qsnp::PileupPipeline, qsnp::MuTectPipeline and qnp::TorrentPipeline are old, they should be deprecated now and delete in future.

@ChristinaXu2017 ChristinaXu2017 mentioned this issue Feb 10, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant