Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception control #219

Open
ChristinaXu2017 opened this issue Dec 7, 2020 · 0 comments
Open

Exception control #219

ChristinaXu2017 opened this issue Dec 7, 2020 · 0 comments

Comments

@ChristinaXu2017
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some old adamajava code used ambiguous exception most of them should be a runtime exception, it is not necessary to catch. eg

static MADefLine parseDefLine(final String value) throws Exception {
      ...
      if (1 > params.length) {
            throw new Exception("Bad defLine format: " + rawValue);
      }

Describe the solution you'd like
It should be more meaningful, eg.

   static MADefLine parseDefLine(final String value) {
      ...
      if (1 > params.length) {
         throw new IllegalArgumentException("Bad defLine format: " + rawValue);
      }

Additional context
We start to replace these exceptions from qio project.

@ChristinaXu2017 ChristinaXu2017 mentioned this issue Jan 29, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant