Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tj-actions/changed-files action to v36 [SECURITY] #153

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Update tj-actions/changed-files action to v36 [SECURITY] #153

merged 1 commit into from
Feb 7, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 2, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
tj-actions/changed-files action major v35 -> v36

GitHub Vulnerability Alerts

CVE-2023-51664

Summary

The tj-actions/changed-files workflow allows for command injection in changed filenames, allowing an attacker to execute arbitrary code and potentially leak secrets.

Details

The changed-files action returns a list of files changed in a commit or pull request which provides an escape_json input enabled by default, only escapes " for JSON values.

This could potentially allow filenames that contain special characters such as ; and ` (backtick) which can be used by an attacker to take over the GitHub Runner if the output value is used in a raw fashion (thus being directly replaced before execution) inside a run block. By running custom commands an attacker may be able to steal secrets such as GITHUB_TOKEN if triggered on other events than pull_request. For example on push.

Proof of Concept

  1. Submit a pull request to a repository with a new file injecting a command. For example $(whoami).txt which is a valid filename.
  2. Upon approval of the workflow (triggered by the pull request), the action will get executed and the malicious pull request filename will flow into the List all changed files step below.
      - name: List all changed files
        run: |
          for file in $; do
            echo "$file was changed"
          done

Example output:

##[group]Run for file in $(whoami).txt; do
    for file in $(whoami).txt; do
        echo "$file was changed"
    done
shell: /usr/bin/bash -e {0}

##[endgroup]
runner.txt was changed

Impact

This issue may lead to arbitrary command execution in the GitHub Runner.

Resolution

  • A new safe_output input would be enabled by default and return filename paths escaping special characters like ;, ` (backtick), $, (), etc for bash environments.

  • A safe recommendation of using environment variables to store unsafe outputs.

- name: List all changed files
  env:
    ALL_CHANGED_FILES: $
  run: |
    for file in "$ALL_CHANGED_FILES"; do
      echo "$file was changed"
    done

Resources

Release Notes

tj-actions/changed-files (tj-actions/changed-files)

v36

Compare Source

Changes in v36.4.1

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.4.1

Changes in v36.4.0

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.4.0

Changes in v36.3.0

🚀 New Features

  • introduces the files_yaml, files_yaml_from_source_file this enables creating filters using YAML.
Example
      - name: Get all test, doc and src files that have changed
        id: changed-files-yml
        uses: tj-actions/changed-files@v36
        with:
          files_yaml: |
            doc:
              - *.md
              - docs/**
              - !docs/README.md
            test:
              - test/**
              - !test/README.md
            src:
              - src/**

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.3.0

Changes in v36.2.1

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.2.1

Changes in v36.2.0

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.2.0

Changes in v36.1.0

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.1.0

Changes in v36.0.18

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.18

Changes in v36.0.17

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.17

Changes in v36.0.16

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.16

Changes in v36.0.15

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.15

Changes in v36.0.14

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.14

Changes in v36.0.13

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.13

Changes in v36.0.12

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.12

Changes in v36.0.11

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.11

Changes in v36.0.10

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.10

Changes in v36.0.9

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.9

Changes in v36.0.8

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.8

Changes in v36.0.7

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.7

Changes in v36.0.6

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.6

Changes in v36.0.5

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.5

Changes in v36.0.4

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.4

Changes in v36.0.3

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.3

Changes in v36.0.2

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.2

Changes in v36.0.1

What's Changed

Full Changelog: tj-actions/changed-files@v36...v36.0.1

Changes in v36.0.0

🚀 Announcing v36: Major Performance Improvements and Enhanced Functionality!

We're thrilled to announce the release of v36! This new version brings a lot of exciting improvements and sets the stage for even more progress in the future.

We've made a major upgrade from a composite action to a javascript action, which brings a number of benefits, including:

  • Performance improvements: We've made significant enhancements to glob filtering which resulted in over 60% faster execution times, with more improvements on the horizon.
  • Verbose logging: We now provide detailed logs to help you better understand what's happening behind the scenes.
  • Clean abstractions/maintainability: Our new architecture is more modular and easier to maintain.
  • Reduced complexity: All functionality is now managed in this project, making it easier for you to use and understand.
  • Improved output file storage: We've made it easier to store output files for further processing.
  • Globstar patterns now work as expected **.js would match all .js files

And that's just the beginning! We've also made some important changes to our inputs and outputs:

🔥🔥 BREAKING CHANGES 🔥 🔥
Inputs
  • json_raw_format: We've changed this input to escape_json, which returns unescaped values when set to false.
  • match_directories: We've removed this input, but you can still get matching directories by setting dir_names to true.
  • diff_relative: This input now has a default value of true.
  • files_from_source_file_separator: We've added this input to enable using a custom separator to split filenames passed via the files_from_source_file input.
  • files_ignore_from_source_file_separator: We've also added this input with a similar use case for the files_ignore_from_source_file input.
Outputs
  • any_(changed|modified|deleted): This output now always returns either a true or false as opposed to an empty string when there are no patterns.
  • only_(changed|modified|deleted): Similar changes also apply here, which now return either a true or false.
Versioning
  • The [...]-sec tags will no longer be created going forward, with the introduction of this new design.

We're excited about all of these changes and can't wait for you to try them out. As always, if you have any questions or feedback, please don't hesitate to reach out!

Full Changelog: tj-actions/changed-files@v35...v36.0.0

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@aviator-app Aviator app
Copy link

aviator-app bot commented Jan 2, 2024 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@performance-testing-bot Performance Testing Bot
Copy link

Unable to locate .performanceTestingBot config file

@secure-code-warrior-for-github Secure Code Warrior for GitHub
Copy link

Micro-Learning Topic: OS command injection (Detected by phrase)

Matched on "command injection"

What is this? (2min video)

In many situations, applications will rely on OS provided functions, scripts, macros and utilities instead of reimplementing them in code. While functions would typically be accessed through a native interface library, the remaining three OS provided features will normally be invoked via the command line or launched as a process. If unsafe inputs are used to construct commands or arguments, it may allow arbitrary OS operations to be performed that can compromise the server.

Try a challenge in Secure Code Warrior

Helpful references
  • OWASP Command Injection - OWASP community page with comprehensive information about command injection, and links to various OWASP resources to help detect or prevent it.
  • OWASP testing for Command Injection - This article is focused on providing testing techniques for identifying command injection flaws in your applications

@pull-request-quantifier-deprecated Pull Request Quantifier (deprecated)
Copy link

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.yml : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 2, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@senior-dev-bot Senior Dev Bot
Copy link

senior-dev-bot bot commented Jan 2, 2024

Hi there! 👋 Thanks for opening a PR. 🎉 To get the most out of Senior Dev, please sign up in our Web App, connect your GitHub account, and add/join your organization AdamOswald. After that, you will receive code reviews beginning on your next opened PR. 🚀

@guide-bot guide-bot
Copy link

guide-bot bot commented Jan 2, 2024

Thanks for opening this Pull Request!
We need you to:

  1. Fill out the description.

    Action: Edit description and replace <!- ... --> with actual values.

  2. Complete the activities.

    Action: Complete If you want to rebase/retry this PR, check this box

    If an activity is not applicable, use '~activity description~' to mark it not applicable.

@difflens DiffLens
Copy link

difflens bot commented Jan 2, 2024

View changes in DiffLens

@AdamOswald AdamOswald merged commit de93045 into main Feb 7, 2024
21 of 62 checks passed
@AdamOswald AdamOswald deleted the renovate/github-tags-tj-actions/changed-files-vulnerability branch February 7, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Extra Small size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AdamOswald