feat: Add Automatic-Module-Name to the generated jar #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, maven would not fail when building applications with JPMS where the module-info.java file is present. Currently the error when trying to use JLink is: Error: automatic module cannot be used with jlink: afterburner.fx from ~/.m2/repository/com/airhacks/afterburner.fx/1.7.0/afterburner.fx-1.7.0.jar [ERROR] Command execution failed.
|
@cchacin I just saw your updates. We are actively maintaining a fork of afterburner.fx at https://github.com/JabRef/afterburner.fx. We also publish to maven central at https://mvnrepository.com/artifact/org.jabref/afterburner.fx. Maybe, you can give it a try. - In case you still work with JavaFX ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, maven would not fail when building
applications with JPMS where the
module-info.javafileis present.
Currently the error when trying to use JLink is: