Changes to FXMLView logging and autoloading of javafx binary css files #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlemmermann
added a commit
to dlsc-software-consulting-gmbh/afterburner.fx
that referenced
this pull request
Aug 20, 2020
…nd autoloading of javafx binary css files AdamBien#68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've really loved using afterburner.fx and I use it for several work projects. There were a few small things that were issues for me which I addressed in my own branch, but I wanted to offer them back into the main repository. The first thing was to change the logging messages in afterburner.fx so that they don't log to System.err. We have had bug reports from customers that think something is wrong because it can't find the css files for all views. The other change I made was to allow the loading of binary css files that javafx produces, we have a few large css files and the ability to use the binary format is important for us.
I implemented a set of tests to check the functionality as well and discovered a small bug in the css loading functionality. When getView() is called multiple times, the css sheet is added multiple times as a reference. I added a check to only add the css/bss files when they haven't already been added.
This is my first proper pull request, so I'm aware I might not be following etiquette, please provide feedback on the pull request if appropriate.