C17-Sharks-Raha #15
Open
C17-Sharks-Raha #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audreyandoy
reviewed
Apr 17, 2022
There was a problem hiding this comment.
Raha!
Your submission has completed all waves and passed all required tests. Your code was easy to read and utilized a lot of helper functions which made your code very neat! I also appreciated your docstrings too 😄
I have added comments to your project on ways to refactor, follow pep8 guidelines, and provided alternative approaches to the waves.
Overall, this project is well-deserving of a 🟢 green 🟢 ✨
Keep up the great work Raha!
Comment on lines
+22
to
+26
| super().__init__(category = "Clothing", condition = condition, age = age) | ||
|
|
||
| def __str__(self): | ||
| return "The finest clothing you could wear." |
There was a problem hiding this comment.
👍 Good work in ensuring that all Clothing instances have a category of "Clothing" by passing the category value into the parent constructor.
Comment on lines
+20
to
+24
| super().__init__(category = "Decor", condition = condition, age = age) | ||
|
|
||
| def __str__(self): | ||
| return "Something to decorate your space." |
Comment on lines
+22
to
+26
| def __init__(self, condition = 0, age = 0): | ||
| super().__init__(category = "Electronics", condition = condition, age = age) | ||
|
|
||
| def __str__(self): | ||
| return "A gadget full of buttons and secrets." |
Comment on lines
+27
to
+47
| self.category = category | ||
| self.condition = condition | ||
| self.age = age | ||
| def __str__(self): | ||
|
|
||
| return f"Hello World!" | ||
|
|
||
| def condition_description(self): | ||
| if 0 <= self.condition < 1: | ||
| return "Just trash it!" | ||
| elif 1 <= self.condition < 2: | ||
| return "Enjoy the last moments!" | ||
| elif 2 <= self.condition < 3: | ||
| return "As good as 30 year old wine!" | ||
| elif 3 <= self.condition < 4: | ||
| return "Better than the new one" | ||
| elif 4 <= self.condition <= 5: | ||
| return "No need to ask!" | ||
| else: | ||
| return False |
There was a problem hiding this comment.
👍 Great work! One minor suggestion:
- Use 1 line of whitespace to separate function definitions from other logic. So in this case, you should have a space above
def __str__(self):.
Comment on lines
+71
to
+73
| inventory = [] | ||
| self.inventory = inventory |
There was a problem hiding this comment.
Good work! We can also use a ternary to assign the value of self.inventory:
self.inventory = inventory if inventory else []
Comment on lines
+79
to
+90
| assert result | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_c not in tai.inventory | ||
| assert item_f in tai.inventory | ||
| assert item_c not in tai.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f not in jesse.inventory | ||
| assert item_c in jesse.inventory |
Comment on lines
+123
to
+133
| assert result | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_f in tai.inventory | ||
| assert item_c not in tai.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f not in jesse.inventory | ||
| assert item_c in jesse.inventory |
Comment on lines
+218
to
+232
| assert result == False | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_c in tai.inventory | ||
| assert item_d not in tai.inventory | ||
| assert item_e not in tai.inventory | ||
| assert item_f not in tai.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f in jesse.inventory | ||
| assert item_a not in jesse.inventory | ||
| assert item_b not in jesse.inventory | ||
| assert item_c not in jesse.inventory |
Comment on lines
+265
to
+279
| assert result == False | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_c in tai.inventory | ||
| assert item_d not in tai.inventory | ||
| assert item_e not in tai.inventory | ||
| assert item_f not in tai.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f in jesse.inventory | ||
| assert item_a not in jesse.inventory | ||
| assert item_b not in jesse.inventory | ||
| assert item_c not in jesse.inventory |
| def condition_description(self): | ||
| if 0 <= self.condition < 1: | ||
| return "Just trash it!" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.