Added support for Si4432 ISM Band #446
Conversation
| type On_Off_Mode is (Off, On); | ||
| type Chip_Power_State is (Idle, RX, TX) with Size => UInt2'Size; | ||
|
|
||
| type Frequency_Type is delta 0.1 range 240.0 .. 960.0 |
There was a problem hiding this comment.
For these types named "_Type" can you come up with better, more descriptive names? The ones above this line are very good, for example.
There was a problem hiding this comment.
Reduced the count of types and renamed some.
There was a problem hiding this comment.
I don't mean to be a jerk about this, but these _Type names are not in the ADL style. Those types in this package without that suffix are much better. For example, why not just use the name Modulation_Source for the type name? Usually, better names for the objects of the type are possible so having the _Type in the type name is not necessary.
|
Ah, now I see what you mean. I'll correct this. Thanks |
|
The names of types has been corrected |
|
On 14-Jun-25 5:48 AM, Andry Ogorodnik wrote:
*ogorodnik* left a comment (AdaCore/Ada_Drivers_Library#446) <https://
github.com/AdaCore/Ada_Drivers_Library/pull/446#issuecomment-2972608907>
The names of types has been corrected
Thanks Andry, this looks very good indeed!
Pat
|
|
Thanks Pat for suggestions! |
Added support for Si4432 EZRadioPRO ISM Band that supports a frequency range between 240 and 960 MHz and output power range between 1 and 20 dBm