Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caroline Nardi - MadLibs - Octos #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

cmn53
Copy link

@cmn53 cmn53 commented Jun 2, 2018

MadLib

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe how you approached tying each input box to a specific work in the MadLib. I passed the words from the selected MadLib to the form as props. I created an initial state by iterating over the words props to create an object with the word keys as keys with empty values. I also created the input elements of the form by iterating over the words props, assigning the name attribute as the word key, the placeholder attribute as the word label, and the value attribute as the state value at the same index as the word in the words prop.
What area of React did you gain more clarity on in this assignment? I think I gained a little more clarity about tying form values to the state.
What are of React do you still have outstanding questions on after this assignment? I needed to make updateWord an arrow function in order to replace the words in the MadLib, but evidently that wasn't necessary for some people. I would like to have a discussion about the different approaches that could be taken to this problem.
Do you have any recommendations on how we could improve this project for the next cohort? A smaller leap between the worksheet and the project would be better if it's meant to be an short afternoon project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant