Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers - Maddie Shields #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ampers - Maddie Shields #42

wants to merge 1 commit into from

Conversation

madaleines
Copy link

Digital Clock

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does jQuery give you that JavaScript doesn't? it's a framework that does the same thing but makes the readability easier
Describe what the following jQuery selector would give you: $('#list') with the list id from css you can do something to add or append the class
What are three major things you learned about JavaScript this week? setting functions to variables, using anonymous functions vs declared functions, trying to use jquery consistently

@tildeee
Copy link

tildeee commented May 23, 2018

Digital Clock

What We're Looking For

Feature Feedback
General
Uses a JavaScript function to get the time x
Uses JavaScript to manipulate the DOM x
Creates a custom function to handle logic x
Overall

Good work!

For the color changing parts, it might be better to remove all the classes and then explicitly add the color class.
You can remove all of the classes using jQuery by passing in no parameters into .removeClass
Also, because you use .toggleClass(), it toggles the class on and off... for example, I can click on purple more than once and it'll turn on and off the purple class

Otherwise you got it!

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants