forked from AdaGold/media-ranker-revisited
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiera - MediaRanker-Revisited - Octos #43
Open
Krashaune
wants to merge
14
commits into
Ada-C9:master
Choose a base branch
from
Krashaune:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f9208ed
Tests written and passing for describe root.
Krashaune 9d67e33
Tests written and passing for describe index.
Krashaune a471247
Tests written and passing for decribe create.
Krashaune 664a6ea
Tests written and passing for describe show.
Krashaune 26bec80
tests written and passing for describe edit.
Krashaune 47b09dc
tests written and passing for describe update.
Krashaune 6c05f0e
Add necessary gems and configuration and updated routes.
Krashaune 50bb096
Added columns to user table.updated gemfile with binding of caller. u…
Krashaune 4e7f836
removed login method from sessions controller. Updated link_to on app…
Krashaune c6c833e
Updated the login logout logic in application view.
Krashaune 02ff043
Updated user fixtures to contain uid and provider. Completed describe…
Krashaune 0c45db9
Added skeleton user tests.
Krashaune 3602b40
Added index and show tests for user.
Krashaune 02b35bd
Updated logout method to post.
Krashaune File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,5 +13,7 @@ | |
!/log/.keep | ||
!/tmp/.keep | ||
|
||
|
||
# Ignore Byebug command history file. | ||
.byebug_history | ||
.env |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Rails.application.config.middleware.use OmniAuth::Builder do | ||
provider :github, ENV["GITHUB_CLIENT_ID"], ENV["GITHUB_CLIENT_SECRET"], scope: "user:email" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
db/migrate/20180417190911_add_and_remove_columns_to_user_table.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
class AddAndRemoveColumnsToUserTable < ActiveRecord::Migration[5.0] | ||
def change | ||
add_column :users, :name, :string | ||
add_column :users, :email, :string | ||
add_column :users, :uid, :integer, null:false | ||
add_column :users, :provider, :string, null:false | ||
|
||
remove_column :users, :username | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,45 @@ | ||
require 'test_helper' | ||
|
||
describe UsersController do | ||
describe 'index' do | ||
it "succeeds when there are users" do | ||
# Assumptions | ||
User.count.must_be :>,0 | ||
|
||
# Act | ||
get users_path | ||
|
||
# Assert | ||
must_respond_with :success | ||
end | ||
|
||
|
||
it "succeeds when there are no users" do | ||
skip | ||
# Assumptions | ||
# User.destroy_all | ||
# | ||
# # Act | ||
# get user_path | ||
# | ||
# # Assert | ||
# must_respond_with :success | ||
end | ||
end | ||
|
||
describe 'show' do | ||
it "succeeds for an existing user" do | ||
get user_path(User.first) | ||
|
||
must_respond_with :success | ||
end | ||
|
||
it "renders 404 not_found for a nonexistent user" do | ||
user_id = User.last.id + 1 | ||
|
||
get user_path(user_id) | ||
|
||
must_respond_with :not_found | ||
end | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should only need this controller action once you implement oauth - not the old
login
one