Mary Ampers #41
Open
Mary Ampers #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
May 2, 2018
| it "succeeds with new valid username and redirects to root path" do | ||
| #not sure why these tests don't work! | ||
| new_user = User.new( | ||
| provider: 'githib', |
There was a problem hiding this comment.
provider githib???
Maybe this is the reason the test fails!
| }.must_change 'User.count', 0 | ||
|
|
||
|
|
||
| must_respond_with :bad_request |
There was a problem hiding this comment.
Your controller is redirecting instead of providing bad request.
| perform_login(existing_user) | ||
| post upvote_path(Work.find(works(:movie).id)) | ||
| must_respond_with :redirect | ||
| must_redirect_to work_path(Work.find(works(:movie).id)) | ||
| end | ||
|
|
||
| it "redirects to the work page after the user has logged out" do |
| end | ||
| end | ||
|
|
||
| describe "upvote" do | ||
|
|
||
| it "redirects to the work page if no user is logged in" do | ||
| existing_user = users(:dan) |
There was a problem hiding this comment.
A flash notice check would also be appropriate in cases like this.
|
|
||
| perform_login(existing_user) | ||
|
|
||
| post login_path, params: { |
There was a problem hiding this comment.
What is this doing? It's a failed login without enough data.
| @@ -1,5 +1,33 @@ | |||
| require 'test_helper' | |||
|
|
|||
| describe UsersController do | |||
| describe "index" do | |||
MediaRanker RevistedWhat We're Looking For
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.