Ampers Steffany #35
Open
Ampers Steffany #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaRanker RevistedWhat We're Looking For
|
CheezItMan
reviewed
May 2, 2018
| User.count.must_equal start_count + 1 | ||
| end | ||
|
|
||
| it "redirects to the login route if given invalid user data" do |
There was a problem hiding this comment.
Maybe also test the flash notice here.
| end | ||
| end | ||
|
|
||
| describe "logout" do |
There was a problem hiding this comment.
What if someone who's not logged in tries to log out?
| @@ -2,4 +2,32 @@ | |||
|
|
|||
| describe UsersController do | |||
|
|
|||
| describe "logged in users" do | |||
| it "redirects to the work page if no user is logged in" do | ||
| post works_path | ||
| must_respond_with :redirect | ||
| flash[:result_text].must_equal "You must be logged in to see that page!" |
There was a problem hiding this comment.
Maybe a better message for some of these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.