forked from AdaGold/media-ranker-revisited
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Octos- Ari- MediaRanker Revisited #33
Open
arrriiii
wants to merge
12
commits into
Ada-C9:master
Choose a base branch
from
arrriiii:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f82622d
udpated testing for upvote
arrriiii eda8783
Completed upvote test
arrriiii 416ef3f
Completed testing for user and works controllers, updated user model …
arrriiii 3938163
Opened testing for session controller
arrriiii 46dee04
OAuth .env file
arrriiii a2bf0cf
Initialize credentials
arrriiii bbf37aa
Method for user log in /out
arrriiii 1de6cd5
Changed method for login user
arrriiii ea1bd0d
new login logic for github sign/login
arrriiii aaddbf0
Removed button access on home page for guest users
arrriiii c42d527
Updated user and session controller with filters
arrriiii 15ddbff
updating testing for users and session controller
arrriiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,4 @@ | |
|
||
# Ignore Byebug command history file. | ||
.byebug_history | ||
.env |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,20 @@ | ||
class User < ApplicationRecord | ||
has_many :votes | ||
has_many :votes, dependent: :destroy | ||
has_many :ranked_works, through: :votes, source: :work | ||
|
||
validates :username, uniqueness: true, presence: true | ||
validates :username, presence: true, uniqueness: true | ||
|
||
def self.build_login(auth_hash) | ||
user_data = { | ||
uid: auth_hash[:uid], | ||
username: auth_hash["info"]["nickname"], | ||
email: auth_hash["info"]["email"], | ||
provider: auth_hash[:provider] | ||
} | ||
user = self.new(user_data) | ||
if user.save | ||
return user | ||
end | ||
end | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Rails.application.config.middleware.use OmniAuth::Builder do | ||
provider :github, ENV["GITHUB_CLIENT_ID"], ENV["GITHUB_CLIENT_SECRET"], scope: "user:email" | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,11 @@ | ||
Rails.application.routes.draw do | ||
# For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html | ||
root 'works#root' | ||
get '/login', to: 'sessions#login_form', as: 'login' | ||
post '/login', to: 'sessions#login' | ||
post '/logout', to: 'sessions#logout', as: 'logout' | ||
|
||
# get '/login', to: 'sessions#login_form', as: 'login' | ||
# post '/login', to: 'sessions#login' | ||
resources :works | ||
post '/works/:id/upvote', to: 'works#upvote', as: 'upvote' | ||
|
||
resources :users, only: [:index, :show] | ||
post '/logout', to: 'sessions#logout', as: 'logout' | ||
get "/auth/:provider/callback", to: "sessions#login", as: 'auth_callback' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class AddColumnsToUser < ActiveRecord::Migration[5.0] | ||
def change | ||
add_column :users, :email, :string | ||
add_column :users, :uid, :integer, null: false | ||
add_column :users, :provider, :string, null: false | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've also added
require_login
as a filter on theApplicationController
, which means it will happen before every single controller action. Your line 5 here adds it again for everything butroot
, but doesn't take it away forroot
. Instead it should be askip_before_action
for only:root
.This is also why all your
WorksController
tests were breaking.This was a tricky one - it took me a while to figure out what was going on 🙂