Selam Ainalem - Amperes #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o account for information coming from Git auth-hash. Also, modified log-in/log-out to utilize Oauth.
…include - all media, all users, and add new work.
MediaRanker RevistedWhat We're Looking For
|
CheezItMan
reviewed
May 2, 2018
| } | ||
|
|
||
| # Create mock account with user | ||
| OmniAuth.config.mock_auth[:github] = OmniAuth::AuthHash.new(@riley_git_hash) |
There was a problem hiding this comment.
You really should DRY this up using the login method in the test_helper.rb file.
| end | ||
|
|
||
| describe 'Destroy' do | ||
| it 'will log out a user' do |
|
|
||
| describe 'Index' do |
| flash[:status].must_equal :failure | ||
| flash[:result_text].must_equal "Could not create book" | ||
| flash[:messages][:title].size.must_equal 1 | ||
| flash[:messages][:title][0].must_equal "can't be blank" |
There was a problem hiding this comment.
Might be more flexible to have:
flash[:messages][:title].must_contain "can't be blank"| post works_path, | ||
| params: | ||
| {work: | ||
| {rating: "5", creator: "world", description: "foo", publication_year: 2008, category: "album"}} |
There was a problem hiding this comment.
How is "album" a bogus category?
Maybe this test would be better named, with bogus data.
|
|
||
| flash[:status].must_equal :failure | ||
| flash[:result_text].must_equal "Could not create album" | ||
| assert_operator flash[:messages][:title].size,:>, 0 |
There was a problem hiding this comment.
You're missing assert-style and spec-style testing.
You can use
flash[:messages][:title].must_be :>, 0|
|
||
| it "renders 404 not_found for a bogus work ID" do | ||
| it "redirects to the work page after the user has logged out" do |
There was a problem hiding this comment.
This test seems a mishmash of things being tested.
|
|
||
| it "succeeds with no media" do | ||
|
|
||
| describe 'Guest User-tests' do |
There was a problem hiding this comment.
You need to test the other routes with guest users and verify that they're redirected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.