Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

&&: Monalisa's MediaRanker-Revisited #22

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

&&: Monalisa's MediaRanker-Revisited #22

wants to merge 10 commits into from

Conversation

MonalisaC
Copy link

No description provided.

@CheezItMan
Copy link

MediaRanker Revisted

What We're Looking For

Feature Feedback
General
Appropriate Tests on WorksController You only have tests with guests for upvote, none of the other routes have tests for unauthenticated users
Appropriate Tests on SessionsController Check
Appropriate Tests on UsersController See my notes on lacking guest vs authenticated users
Completed OAuth It works!
Overall Overall not bad, but you need to have more through testing for guest users

CheezItMan
CheezItMan reviewed May 2, 2018
View reviewed changes
test/controllers/sessions_controller_test.rb

must_redirect_to root_path

User.count.must_equal start_count
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking a flash notice here would also be appropriate.

test/controllers/users_controller_test.rb
@@ -1,5 +1,49 @@
require 'test_helper'

describe UsersController do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests for guest vs authenticated users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MonalisaC @CheezItMan