Ampers: Abinnet Ainalem #45

Abiaina · 2018-02-08T17:07:27Z

Calculator

Congratulations! You're submitting your assignment.

Question	Answer
Describe how you stored user input in your program?	As an array or in a variable
How did you determine what operation to perform?	By comparing strings
Do you feel like you used consistent indentation throughout your code?	Yes I used the auto indent we created on the first day
If you had more time, what would you have added to or changed about the program?	I would have added more operations to process and included the ability to compute more complex equations. Also my error message doesn't always show the user their exact error. This would be my first issue to address.

CheezItMan · 2018-02-09T16:28:38Z

Feature	Feedback
Takes in two numbers and an operator and performs the mathematical operation.	Check
Baseline
Readable code with consistent indentation.	Check
Extras	User can enter values in an equation format.
Overview	Nice work, nice use of `.split` to divide out the input. Your code was pretty readable and easy to follow.

CheezItMan · 2018-02-09T16:25:19Z

calculator.rb

+  user_entry = gets.chomp.downcase.split(" ")
+
+  numbers = [user_entry[0], user_entry[2]]
+  numbers.each do |num|


You might also check to ensure that the length of user_entry is at least 3.

CheezItMan · 2018-02-09T16:26:01Z

calculator.rb

+
+  if points_of_confusion.length > 0
+    puts "I was unable to solve your equation because:"
+    points_of_confusion.each {|issue| puts issue}


I like how you collected the errors into an array.

calculator hw

7d688d1

CheezItMan reviewed Feb 9, 2018

View reviewed changes