C22 - Aksana, Kristina, Sarah #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aksana <[email protected]>
…ry. Updated image placeholders with URLs, alt text, captions, and credits.
…esheets for Index, Facts, and Gallery. Added link to Google Fonts in Index, Gallery, and Facts. Added baseline CSS styling: h1-h4: modified font and text color. body: background color, left and right margins established, text aligned to center. li: inline display, left and right padding between elements. footer: height, top and bottom margins established. Changed index banner image and added custom width to Index CSS. Moved nav element outside of main in Facts and Gallery. Added nav element to footer of Gallery and modified copyright message. Co-authored-by: Kristina N <[email protected]> Co-authored-by: Aksana <[email protected]>
…ardless of page length
…ncy buttons. Modified nav links to use aforementioned fancy buttons. Added rounded edges, box shadows to images. Updated artwork title.
… cursor image, removed one.
Co-authored-by: Kristina N <[email protected]> Co-authored-by: Aksana <[email protected]>
…ine. Added surprise audio treat to the Gallery page. Modified main Gallery section to display figure columns horizontally, scrolling instead of wrapping to a new line. Removed lower nav section due to change in page layout. Co-authored-by: Kristina N <[email protected]> Co-authored-by: Aksana <[email protected]>
…k from previous font to current. Modified headings for Facts section. Removed extra verbiage in Facts footer to make copyright consistent across all pages.
…nd body text colors on Gallery to meet WCAG AA contrast standards. Removed elements in gallery stylesheet that were moved/duplicated in baseline stylesheet. Identified and removed unnecessary declarations in baseline stylesheet. Adjusted top margin of h1 on Gallery to align better with other pages. Added additional accessibility for audio element in Gallery.
Wave 2 + Wave 3
yangashley
reviewed
Nov 21, 2024
There was a problem hiding this comment.
👍 good that you remembered to move index.html to th e project root.
Comment on lines
+32
to
+50
| <section> | ||
| <h2>What Are Invisible Pets? </h2> | ||
| <ul> | ||
| <li class="list-facts">Invisible pets are companions you can't see but can feel! They’re perfect for anyone with a wild imagination who’s ready to adopt a one-of-a-kind, low-maintenance friend. They can be anything: invisible dogs, cats, dragons, or even something entirely unique to the owner.</li> | ||
| <li class="list-facts">Invisible pets don’t shed, bark, meow, or require a litter box!</li> | ||
| </ul> | ||
| <h2>Meet Our Most Popular Breeds </h2> | ||
| <ul> | ||
| <li class="list-facts"><span class="text-facts">Phantomo Cats:</span> Known for their silent purrs, they keep you company without knocking things over.</li> | ||
| <li class="list-facts"><span class="text-facts">Breezy Beagles:</span> Experts at invisible fetch games, and known for sniffing out imaginary treats.</li> | ||
| <li class="list-facts"><span class="text-facts">Cloud Dragons:</span> They hover near you like a soft breeze and love to "breathe" invisible fire.</li> | ||
| </ul> | ||
| <h2>Invisible Pet Care 101</h2> | ||
| <ul> | ||
| <li class="list-facts"><span class="text-facts">Feeding:</span> Invisible pets have refined tastes, but fortunately, they love imaginary food! Just pretend to pour it out, and they’ll be thrilled.</li> | ||
| <li class="list-facts"><span class="text-facts">Exercise:</span> Invisible dogs love long, pretend walks, while invisible cats enjoy imaginary sunbeams. </li> | ||
| <li class="list-facts"><span class="text-facts">Bathing:</span> Baths are easy—just pretend to wash them, and they’ll be clean in no time!</li> | ||
| </ul> | ||
| </section> |
There was a problem hiding this comment.
You use semantic elements appropriately in facts.html. Putting "Meet Our Most Popular Breeds", "Meet Our Most Popular Breeds", and "Invisible Pet Care 101" in a single section tag, which works! I could also see putting each of these parts into their own section elements too.
I don't think you need it here and it's not necessarily correct, but I thought I'd call it out to highlight how different people interpret what elements are needed on a page.
| <h2>Invisible Pets of the Week</h2> | ||
| <div class="figure-container"> | ||
| <figure class="figure-column"> | ||
| <img src="/images/invisible-pet_1.jpg" alt="Sir Nix-A-Lot, a chameleon, rests invisibly on a branch in the rainforest"> |
There was a problem hiding this comment.
Nice working including the alt tags for these images!
Comment on lines
+56
to
+58
| <audio controls autoplay aria-label="Dogsong from Undertale (MIDI style)"> | ||
| <source src="/assets/DogMIDI.mp3" type="audio/mp3"> | ||
| </audio> |
| width: 80%; | ||
| } | ||
|
|
||
| html { |
There was a problem hiding this comment.
This works! Could also put it on body too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.