Lions - Jessica Ambriz-Madrigal #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 4, 2022
Comment on lines
+42
to
+46
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Comment on lines
+14
to
+37
| if self.completed_at is None: | ||
| if self.goal_id is None: | ||
| task_dict = { | ||
| "id":self.id, | ||
| "title":self.title, | ||
| "description":self.description, | ||
| "is_complete": False | ||
| } | ||
| else: | ||
| task_dict = { | ||
| "id":self.id, | ||
| "goal_id": self.goal_id, | ||
| "title":self.title, | ||
| "description":self.description, | ||
| "is_complete": False | ||
| } | ||
| else: | ||
| task_dict = { | ||
| "id":self.id, | ||
| "title":self.title, | ||
| "description":self.description, | ||
| "is_complete": True | ||
| } | ||
| return task_dict |
There was a problem hiding this comment.
This seems a little over-complicated. Could you do the basic dictionary in one block and then add key-value pairs based on an if-else?
| task_bp = Blueprint("task_bp",__name__, url_prefix="/tasks") | ||
|
|
||
| def get_one_task_or_abort(task_id): |
Comment on lines
+30
to
+32
| "description" not in request_body: | ||
| return jsonify({"details": "Invalid data"}), 400 |
There was a problem hiding this comment.
Good validation here. However I think you should also indicate what data is invalid.
Comment on lines
+42
to
+49
| "task":{ | ||
| "id" : new_task.id, | ||
| "title" : new_task.title, | ||
| "description" : new_task.description, | ||
| "is_complete" : new_task.is_complete | ||
| } | ||
| }, 201 |
There was a problem hiding this comment.
This return value might be useful as a helper function for reuse.
Comment on lines
+57
to
+64
| tasks = Task.query.all() | ||
|
|
||
| if sort_param == "desc": | ||
| tasks = Task.query.order_by(Task.title.desc()).all() | ||
|
|
||
| if sort_param == "asc": | ||
| tasks = Task.query.order_by(Task.title.asc()).all() |
There was a problem hiding this comment.
This might cause Task.query to execute twice making this potentially twice as slow as it needs to be.
Comment on lines
+117
to
+128
| SLACK_BOT_TOKEN = os.environ.get("SLACK_BOT_TOKEN") | ||
|
|
||
| headers = { | ||
| "Authorization" : f"Bearer {SLACK_BOT_TOKEN}" | ||
| } | ||
| params = { | ||
| "channel": "task-notifications", | ||
| "text": f"Someone just completed the task {update_is_valid_id.title}" | ||
| } | ||
|
|
||
| requests.get(url=SLACK_PATH, headers=headers, params=params) |
There was a problem hiding this comment.
The Slack portion would make a good candidate for a helper function.
Comment on lines
+165
to
+166
| return jsonify({"details": "Invalid data"}), 400 |
There was a problem hiding this comment.
Again indicating what data is invalid would be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.