paper_Manu #70
Open
paper_Manu #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 9, 2021
| @@ -0,0 +1,11 @@ | |||
| from swap_meet.item import Item | |||
| @@ -0,0 +1,23 @@ | |||
| #wave2 | |||
| class Item(): #parens allow inheritance | |||
| def __init__(self, category="", condition=0): | |||
| self.category = category | ||
| self.condition = condition | ||
|
|
||
| def __str__(self): |
| def __str__(self): | ||
| return("Hello World!") | ||
|
|
||
| def condition_description(self): |
| self.inventory = inventory | ||
|
|
||
|
|
||
| def add(self, add_item): |
Comment on lines
+41
to
+42
| if len(self.inventory) == 0 or len(friend.inventory) == 0: | ||
| return False |
There was a problem hiding this comment.
This is a little simpler due to the fact that [] is falsey.
Suggested change
| if len(self.inventory) == 0 or len(friend.inventory) == 0: | |
| return False | |
| if not self.inventory or not friend.inventory: | |
| return False |
| return self.swap_items(friend, my_item, their_item) | ||
|
|
||
| #wave6 | ||
| def get_best_by_category(self, category): |
Comment on lines
+64
to
+65
| #DRYup using swap_items | ||
| #return self.swap_items(other, my_item, their_item) |
| best_by_category = item | ||
| return best_by_category | ||
|
|
||
| def swap_best_by_category(self, other, my_priority, their_priority): |
Comment on lines
+82
to
+103
| # if __name__ == "__main__": | ||
|
|
||
| # from item import Item | ||
| # item1 = Item("jacket") | ||
|
|
||
|
|
||
| # x = Vendor() | ||
| # print(x.inventory) | ||
|
|
||
| # y = Vendor([item1]) | ||
| # print(y.inventory) | ||
|
|
||
| # x.add(1) | ||
| # print(x.inventory) | ||
|
|
||
| # print (x.remove(3)) | ||
|
|
||
| # if x.remove(1): | ||
| # print("remove 1") | ||
|
|
||
| # y.get_by_category("jacket") | ||
| # print(y.get_by_category) |
There was a problem hiding this comment.
Just consider removing the commented code prior to submitting.
Suggested change
| # if __name__ == "__main__": | |
| # from item import Item | |
| # item1 = Item("jacket") | |
| # x = Vendor() | |
| # print(x.inventory) | |
| # y = Vendor([item1]) | |
| # print(y.inventory) | |
| # x.add(1) | |
| # print(x.inventory) | |
| # print (x.remove(3)) | |
| # if x.remove(1): | |
| # print("remove 1") | |
| # y.get_by_category("jacket") | |
| # print(y.get_by_category) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.