Rock - Abigail C. #65
Conversation
…get_by_category/Wave01 and Wave02
…Parent Class being Item / Wave05
… swap_best_by_category methods
| self.category = "Clothing" | ||
| self.condition = condition |
There was a problem hiding this comment.
This looks great! You can further refactor this by using super() to inherit the category and condition attributes since Clothing is a child class.
| self.category = "Clothing" | ||
| self.condition = condition |
There was a problem hiding this comment.
The two lines can be reduced to
| self.category = "Clothing" | |
| self.condition = condition | |
| super().__init__("Clothing", condition) |
| self.category = "Decor" | ||
| self.condition = condition |
There was a problem hiding this comment.
Same recommendation as above to use super()
| self.category = "Electronics" | ||
| self.condition = condition |
There was a problem hiding this comment.
Beating a dead horse but same as above about super()
| self.category = category | ||
| self.condition = condition |
There was a problem hiding this comment.
Is condition always going to be an integer? A way to make your code more robust is to also check if condition is the correct data type you're expecting. What about float values or strings?
| ''' | ||
| reassigns the stringified item | ||
| ''' | ||
| return "Hello World!" |
| if self.condition == 5: | ||
| five_condition_description = "Great Condition" | ||
| return five_condition_description | ||
| elif self.condition == 4: | ||
| four_condition_description = "Good Condition" | ||
| return one_condition_description | ||
| elif self.condition == 3: | ||
| three_condition_description = "Okay Condition" | ||
| return one_condition_description | ||
| elif self.condition == 2: | ||
| two_condition_description = "Poor Condition" | ||
| return one_condition_description | ||
| elif self.condition == 1: | ||
| one_condition_description = "Very Poor Condition" | ||
| return one_condition_description |
There was a problem hiding this comment.
One good thought exercise is how mighty our conditionals change if condition was a float?
| for item in other_vendor.inventory: | ||
| if item == other_vendor_item: | ||
| self.inventory.append(item) | ||
| other_vendor.inventory.remove(item) | ||
| for item in self.inventory: | ||
| if item == vendor_item: | ||
| other_vendor.inventory.append(item) | ||
| self.inventory.remove(item) | ||
| return True |
| if item.condition > largest_num: | ||
| largest_num = item.condition | ||
| largest_item = item | ||
| return largest_item |
| vendor_item = other.get_best_by_category(my_priority) | ||
| other_item = self.get_best_by_category(their_priority) | ||
| self.swap_items(other, other_item, vendor_item) | ||
|
|
No description provided.