Paper, Al #61
Open
Paper, Al #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nteract with items. Also made notes in test_wave_01.py - passed all test in wave 1.
… method, get_by_category() takes a str -category. loops, grabs matches in inventory with item.category. returns list. Passed Wave 2.
…r objects. added strigify method to item.py that returns Hello World! Passed Wave 3
…pdate as soon as I can get back to work
…d to the Vendor class. Passed all tests in Wave 6
CheezItMan
reviewed
Apr 9, 2021
There was a problem hiding this comment.
Nice work Al, you hit the learning goals here. Well done. I had a few comments, mostly on code style. Well done.
You might consider using DocStrings in your methods, to comment and document them. It might take the place of your inline methods.
Comment on lines
+18
to
+19
| def clothing_condition_description(self, condition): | ||
| super().condition_description() |
There was a problem hiding this comment.
I don't think these methods are needed.
| # the instances/obects of the Item class will be components of the Vendor class' instance - vendor objects "have many" item objects | ||
|
|
||
| ### test 2.1 PASSED ### setting the default argument makes it optional | ||
| class Item: |
| self.inventory = [] | ||
| else: | ||
| self.inventory = inventory | ||
| # self.get_by_category = get_by_category() -- this is a Vendor method and does not need to be an attribute. |
|
|
||
| ### test 1.1 PASSED ### test 1.2 PASSED ### | ||
| class Vendor: | ||
| def __init__(self, inventory = None): #get_by_category, |
| # self.get_by_category = get_by_category() -- this is a Vendor method and does not need to be an attribute. | ||
|
|
||
| ### test 1.3 PASSED ### | ||
| def add(self, item): |
| return remove_item | ||
|
|
||
| ### test 2.2 PASSED ### test 2.3 PASSED ### | ||
| def get_by_category(self, category): |
| #^^^returns an empty list if no item-instances belong to the category passed in. | ||
|
|
||
| ## PASSED ## test 3.2 ## test 3.3 ## test 3.4 ## test 3.5 ## test 3.6 ## | ||
| def swap_items(self, friendor, my_item, their_item): |
There was a problem hiding this comment.
👍 , but you don't need the else: See my example further below.
Comment on lines
+66
to
+72
| else: | ||
| print("something else") | ||
| friendor.inventory.append(self.inventory[0]) | ||
| self.inventory.remove(self.inventory[0]) | ||
| self.inventory.append(friendor.inventory[0]) | ||
| friendor.inventory.remove(friendor.inventory[0]) | ||
| return True |
There was a problem hiding this comment.
You don't need the else: here.
Suggested change
| else: | |
| print("something else") | |
| friendor.inventory.append(self.inventory[0]) | |
| self.inventory.remove(self.inventory[0]) | |
| self.inventory.append(friendor.inventory[0]) | |
| friendor.inventory.remove(friendor.inventory[0]) | |
| return True | |
| friendor.inventory.append(self.inventory[0]) | |
| self.inventory.remove(self.inventory[0]) | |
| self.inventory.append(friendor.inventory[0]) | |
| friendor.inventory.remove(friendor.inventory[0]) | |
| return True |
Also friendor??
| return True | ||
|
|
||
| ### test 6.1 PASSED ### test 6.2 PASSED ### test 6.3 PASSED ### | ||
| def get_best_by_category(self, category): |
There was a problem hiding this comment.
Nice use of a lambda (sort of) function!
|
|
||
|
|
||
| ### test 6.4 PASSED ### test 6.5 PASSED ### test 6.6 PASSED ### | ||
| def swap_best_by_category(self, other, my_priority, their_priority): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my completed swap_meet project.