Rock - Priscille #50
Open
Rock - Priscille #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… swap the best item by category.
spitsfire
reviewed
Apr 12, 2021
Comment on lines
+4
to
+5
| def __init__(self, category="Clothing", condition=0, age=0): | ||
| super().__init__(category, condition, age) |
There was a problem hiding this comment.
👍 this works perfectly! But it still lets the user change the category, and we don't want that. class Clothing will always have the category "clothing." So let's try this:
Suggested change
| def __init__(self, category="Clothing", condition=0, age=0): | |
| super().__init__(category, condition, age) | |
| def __init__(self, condition=0, age=0): | |
| super().__init__("clothing", condition, age) |
| @@ -0,0 +1,10 @@ | |||
| from swap_meet.item import Item | |||
|
|
|||
| class Decor(Item): | |||
There was a problem hiding this comment.
👍 We can do the same thing here as we did above!
| @@ -0,0 +1,10 @@ | |||
| from swap_meet.item import Item | |||
|
|
|||
| class Electronics(Item): | |||
There was a problem hiding this comment.
👍 We can do the same thing here as we did above!
Comment on lines
+3
to
+15
| def __init__(self, category = "", condition = 0, age = 0): | ||
| if category is None: | ||
| self.category = "" | ||
| else: | ||
| self.category = category | ||
| if condition is None: | ||
| self.condition = 0 | ||
| else: | ||
| self.condition = condition | ||
| if age is None: | ||
| self.age = 0 | ||
| else: | ||
| self.age = age |
There was a problem hiding this comment.
this works good! But our default parameters, like category="" already do what the if-else statements do. so let's let the default parameters do all the work.
Suggested change
| def __init__(self, category = "", condition = 0, age = 0): | |
| if category is None: | |
| self.category = "" | |
| else: | |
| self.category = category | |
| if condition is None: | |
| self.condition = 0 | |
| else: | |
| self.condition = condition | |
| if age is None: | |
| self.age = 0 | |
| else: | |
| self.age = age | |
| def __init__(self, category = "", condition = 0, age = 0): | |
| self.category = category | |
| self.condition = condition | |
| self.age = age |
now category will be assigned "" if the user doesn't add in an argument. It will do what if-else statements are doing for us!
| def __str__(self): | ||
| return "Hello World!" | ||
|
|
||
| def condition_description(self): |
Comment on lines
+42
to
+44
| item_a = self.inventory[0] | ||
| item_d = vendor_friend.inventory[0] | ||
| result = self.swap_items(vendor_friend, item_a, item_d) |
There was a problem hiding this comment.
we could get rid of these two variables if we wanted!
Suggested change
| item_a = self.inventory[0] | |
| item_d = vendor_friend.inventory[0] | |
| result = self.swap_items(vendor_friend, item_a, item_d) | |
| result = self.swap_items(vendor_friend, self.inventory[0], vendor_friend.inventory[0]) |
| result = self.swap_items(vendor_friend, item_a, item_d) | ||
| return result | ||
|
|
||
| def get_best_by_category(self, category_name): |
| best_item = item | ||
| return best_item | ||
|
|
||
| def swap_best_by_category(self, other, my_priority, their_priority): |
|
|
||
| # Optional Enhancements: item by age | ||
|
|
||
| def get_newest_item(self): |
| newest_item = item | ||
| return newest_item | ||
|
|
||
| def swap_by_newest(self, business_partner, my_newest_item, their_newest_item): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.