Rock - Aeron Roemer #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 7, 2021
Comment on lines
+12
to
+13
| if (this.front == 0 && (this.rear == this.store.size - 1)){ | ||
| return false |
There was a problem hiding this comment.
This if condition will prevent the rear from wrapping around the buffer, which is the behavior you want.
I think it should instead be:
Suggested change
| if (this.front == 0 && (this.rear == this.store.size - 1)){ | |
| return false | |
| if ((this.rear +1) % this.store.size == this.front){ | |
| return false |
| this.rear = (this.rear + 1) % this.size | ||
| this.store[this.rear] = element | ||
| } | ||
|
|
||
| } | ||
|
|
||
| dequeue() { |
| } | ||
|
|
||
| front() { | ||
| throw new Error("This method has not been implemented!"); | ||
| frontItem() { |
| } | ||
|
|
||
| size() { | ||
| throw new Error("This method has not been implemented!"); | ||
| sizeOfQ() { |
There was a problem hiding this comment.
👍 , although since this size method is a member of the Queue instance, the "Q" is kind of assumed.
| } | ||
|
|
||
| pop() { | ||
| throw new Error("This method has not been implemented!"); | ||
| if (!this.store.head) return null; |
There was a problem hiding this comment.
You could also use the linked list empty method.
| throw new Error("This method has not been implemented!"); | ||
| if (!this.store.head) return true; | ||
|
|
||
| if (this.store.head.next) return false; |
There was a problem hiding this comment.
This could give a false empty when the Stack has 1 element. You can just return false if the prior if statement doesn't exit.
Suggested change
| if (this.store.head.next) return false; | |
| return false; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forked before the changes & used my own linked list from the previous assignment.