Jing - Fire #32
Open
Jing - Fire #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Nov 20, 2020
There was a problem hiding this comment.
Media Ranker
Functional Requirements: Manual Testing
| Criteria | yes/no |
|---|---|
| Before logging in | -- |
| 1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight | ✔️ |
| 2. Can go into a work's show page | ✔️ |
| 3. Verify unable to vote on a work, and get a flash message | ✔️ |
| 4. Can edit this work successfully, and get a flash message | ✔️ |
| 5. Can go to "View all media" page and see three lists of works, sorted by vote | |
| 6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message | |
| 7. Can create a new work successfully. Note the URL for this work's show page | ✔️ |
| 8. Can delete this work successfully | ✔️ |
| 9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view) | head |
| 10. Verify that the "View all users" page lists no users | ✔️ |
| Log in | -- |
| 11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons | ✔️ |
| 12. Your username is listed in "View all users" page | ✔️ |
| 13. Verify that number of votes determines the Media Spotlight | ✔️ |
| 14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page | ✔️ |
| 15. Voting on the same work twice produces an error and flash message, and there is no extra vote | ✔️ |
| Log out | -- |
| 16. Logging out showed a flash message and changed the UI | ✔️ |
| 17. Logging in as a new user creates a new user | ✔️ |
| 18. Logging in as an already existing user has a specific flash message | ✔️ |
Major Learning Goals/Code Review
| Criteria | yes/no |
|---|---|
| 1. Sees the full development cycle including deployment, and the app is deployed to Heroku | ✔️ |
| 2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker | ✔️, close enough |
| 3. Practices git with at least 25 small commits and meaningful commit messages |
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
| Criteria | yes/no |
|---|---|
4. Routes file uses resources for works |
✔️ |
| 5. Routes file shows intention in limiting routes for voting, log-in functionality, and users | ✔️ |
| 6. The homepage view, all media view, and new works view use semantic HTML | ✔️ |
| 7. The homepage view, all media view, and new works view use partials when appropriate | |
8. The model for media (likely named work.rb) has_many votes |
✔️ |
| 9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category | |
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user |
✔️ |
11. Some controller, likely the WorksController, has a controller filter for finding a work |
|
12. The WorksController uses strong params |
✔️ |
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash |
✔️ |
Testing Rails Apps
| Criteria | yes/no |
|---|---|
| 14. There are valid fixtures files used for users, votes, and works | ✔️ |
| 15. User model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️ |
| 16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote) | ✔️ |
| 17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️ |
| 18. Work model has tests with a section on all business logic methods in the model, including their edge cases |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 14+ in Functional Requirements: Manual Testing && 14+ in Code Review | 💚 |
Code Style Bonus Awards
Was the code particularly impressive in code style for any of these reasons (or more...?)
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Descriptive/Readable | ✅ |
| Logical/Organized | ✅ |
Summary
Nice work overall, you hit the main learning goals here. I like the syling and your use of filters and using .where and .order to filter and sort the works from the database. It just should be in model methods.
Areas for improvement:
- Work at adding model methods for your business logic.
- Look toward edge-cases for tests.
- Prefer redirects and renders over
head.
Comment on lines
+2
to
+5
| validates :category, presence: true | ||
| validates :category, inclusion: { in: ["album", "book", "movie"], | ||
| message: "category can only be album, book, or movie." } | ||
| validates :title, presence: true, uniqueness: true |
Comment on lines
+10
to
+23
| # def top_10_albums | ||
| # albums = Work.where(category: "album") | ||
| # return albums.order(votes: :desc).limit(10) | ||
| # end | ||
| # | ||
| # def top_10_books | ||
| # books = Work.where(category: "book") | ||
| # return books.order(votes: :desc).limit(10) | ||
| # end | ||
| # | ||
| # def top_10_movies | ||
| # movies = Work.where(category: "movie") | ||
| # return movies.order(votes: :desc).limit(10) | ||
| #end |
Comment on lines
+5
to
+7
| @albums = @work.where(category: "album") | ||
| @books = @work.where(category: "book") | ||
| @movies = @work.where(category: "movie") |
Comment on lines
+6
to
+8
| @albums = @work.where(category: "album").order(vote_count: :desc).limit(10) | ||
| @books = @work.where(category: "book").order(vote_count: :desc).limit(10) | ||
| @movies = @work.where(category: "movie").order(vote_count: :desc).limit(10) |
There was a problem hiding this comment.
These would be great as model methods.
Comment on lines
+2
to
+7
| before_action :current_user | ||
|
|
||
| def current_user | ||
| @current_user = User.find_by(id: session[:user_id]) if session[:user_id] | ||
| return | ||
| end |
Comment on lines
+64
to
+65
| head :not_found | ||
| return |
There was a problem hiding this comment.
Again avoid using head at this point, we have better tools.
Comment on lines
+4
to
+6
| resources :works do | ||
| resources :votes, only: [:index, :create] | ||
| end |
| get "/users/current", to: "users#current", as: "current_user" | ||
| get '/users/:id', to: "users#show", as: "user" | ||
|
|
||
| post '/works/:id/upvote', to: "votes#create", as: "upvote" |
There was a problem hiding this comment.
This is unnecessary
Suggested change
| post '/works/:id/upvote', to: "votes#create", as: "upvote" |
Comment on lines
+28
to
+39
| <ul class="list-group top-ten__list"> | ||
| <% @movies.each do |movie| %> | ||
| <li class="list-group-item"> | ||
| <h4> | ||
| <%= link_to movie.title, work_path(movie) %> | ||
| <small class="top-ten__creator">by <%= movie.creator %></small> | ||
| </h4> | ||
| <p><%=movie.vote_count %> votes</p> | ||
| </li> | ||
| <% end %> | ||
|
|
||
| </ul> |
There was a problem hiding this comment.
I just want to point out that this code is repeated several times and similar code in several different views.
You can dry this up with a partial and just pass to the partial the collection of works to display.
Comment on lines
+10
to
+13
| # def top_10_albums | ||
| # albums = Work.where(category: "album") | ||
| # return albums.order(votes: :desc).limit(10) | ||
| # end |
There was a problem hiding this comment.
You should have made these class methods.
Suggested change
| # def top_10_albums | |
| # albums = Work.where(category: "album") | |
| # return albums.order(votes: :desc).limit(10) | |
| # end | |
| def self.top_10_albums | |
| albums = Work.where(category: "album") | |
| return albums.order(votes: :desc).limit(10) | |
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Reflection
sessionandflash? What is the difference between them?