Earth - Olga #38
Open
Earth - Olga #38
+335
−369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 1, 2020
There was a problem hiding this comment.
MediaRanker Revisted
Major Learning Goals/Code Review
Functional Requirements
| Functional Requirement | yes/no |
|---|---|
| Completed OAuth: Logging in goes through GitHub | ✔️ |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 1 in Functional Requirements and controller methods are cleanly written with appropriate model methods for Oauth | 💚 |
Summary
Nice work, this functions, just remember to remove the .env file from git.
| # redirect_to root_path | ||
| # end | ||
| # | ||
| def create |
Comment on lines
+52
to
+55
| <% if session[:user_id] %> | ||
| <li class="nav-item app-header__nav_item"> | ||
| <%= link_to "Log out", logout_path, method: "post" %> | ||
| </li> |
There was a problem hiding this comment.
This is fine, but it would be nice to have a controller filter that sets @current_user or something so you could use that instance variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Media Ranker Revisited
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection