-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aimee 👾 - Fire 🔥 #29
base: master
Are you sure you want to change the base?
Aimee 👾 - Fire 🔥 #29
Conversation
…its)...so I'm starting over. npm install complete
…oun, adverb, verb, adjective, noun). Player is able to fill out the six text input fields (can press submit and fields will clear). Placeholder text in each text input describes what to fill in.
… player and add each player's submission (poem lines) to the poem.
…k to submit the current poem line. current player number is now displayed.
…mitted poem line.
…sn't seem to be working
…ing in FinalPoem.test - this test was passing before when none of the text was acutally dispalyed :\
…ayers can keep submitting lines and the last line will be displayed. Once the poem is submitted the submission button and the most recent submisison dissapear
…led in - I really like this style
A couple of tests failed, but the project seems to be working overall. I'd like to get some help/feedback on how to dry up the code, make better use of "fields," and what to do about the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall not bad Aimee, you had things mostly working. See my comments on the FinalPoem.js
file. Some of the other tests are failing because the tests are unable to select the correct input fields and enter text. They make assumptions about your code that is different.
Other than that you have a fully functional Exquisite Corpse game. Nice work. You did demonstrate the skills we were assessing.
Co-authored-by: Chris M <[email protected]>
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection