Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aimee 👾 - Fire 🔥 #29

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Aimee 👾 - Fire 🔥 #29

wants to merge 14 commits into from

Conversation

marks214
Copy link

@marks214 marks214 commented Jan 7, 2021

Assignment Submission: Exquisite React

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt Response
Define in your own words: What does "state" in React mean? How do we use it? State is the data a component maintains. Props (how we pass data from component to component) cannot be changed by the component receiving the props. Props are immutable. So state is a way for a component to both change and maintain data.
Describe the relationships between the components on a high-level: which components were siblings? Which components were nested within each other? The components PlayerSubmissionForm, RecentSubmission, and FinalPoem are siblings. They are all nested together (children) in the Game component. The Game component is then nested in the App.
How did this project differ from in-class examples? The in-class examples didn't cover all of the different ways to do conditional rendering. Also, this project had 3 child components nested in one component.
How was this project similar to in-class examples? Specific to this week, the advanced forms in-class examples showed how to use a single function to update any field based on a parameter and how to mark an input field (displayed to the user) as pink/green based on valid input.

…its)...so I'm starting over. npm install complete
…oun, adverb, verb, adjective, noun). Player is able to fill out the six text input fields (can press submit and fields will clear). Placeholder text in each text input describes what to fill in.
… player and add each player's submission (poem lines) to the poem.
…k to submit the current poem line. current player number is now displayed.
…ing in FinalPoem.test - this test was passing before when none of the text was acutally dispalyed :\
…ayers can keep submitting lines and the last line will be displayed. Once the poem is submitted the submission button and the most recent submisison dissapear
@marks214
Copy link
Author

marks214 commented Jan 7, 2021

A couple of tests failed, but the project seems to be working overall. I'd like to get some help/feedback on how to dry up the code, make better use of "fields," and what to do about the tests.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall not bad Aimee, you had things mostly working. See my comments on the FinalPoem.js file. Some of the other tests are failing because the tests are unable to select the correct input fields and enter text. They make assumptions about your code that is different.

Other than that you have a fully functional Exquisite Corpse game. Nice work. You did demonstrate the skills we were assessing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants