Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaves - Cloudy #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Leaves - Cloudy #26

wants to merge 1 commit into from

Conversation

OhCloud
Copy link

@OhCloud OhCloud commented Feb 24, 2020

No description provided.

CheezItMan
CheezItMan reviewed Feb 25, 2020
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you hit the basic learning goals, with some issues on space/time complexity. Check out my comments and let me know if you have any questions.

Nice job here Cloudy!

lib/tree.rb

return current_node
end

def add(key, value)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space/time complexity?

lib/tree.rb
Comment on lines 76 to 78
# Time Complexity:
# Space Complexity:
def find(key)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big O?

lib/tree.rb
# Time Complexity:
# Space Complexity:
def inorder
raise NotImplementedError
def inorder #return [] with order were given
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for bigO

lib/tree.rb
preorder_helper(current_node.right, list)
return list
end

# Time Complexity:
# Space Complexity:
def preorder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for bigO

lib/tree.rb
end

# Time Complexity:
# Space Complexity:
def postorder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for bigO

lib/tree.rb



def height_helper(current_node)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 except for bigO. nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OhCloud @CheezItMan