forked from AdaGold/stacks-queues
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaves - Bri #47
Open
brilatimer
wants to merge
3
commits into
Ada-C12:master
Choose a base branch
from
brilatimer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Leaves - Bri #47
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,46 @@ | ||
require_relative './stack.rb' | ||
|
||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
# Time Complexity: O(n) | ||
# Space Complexity: O(n) | ||
def balanced(string) | ||
raise NotImplementedError, "Not implemented yet" | ||
# is it evenly divided by 2? If yes, then return false | ||
# equal number of open parans and close parens | ||
# make a new stack, make balanced = true | ||
# go through each string using each_char | ||
# if open parens, push to stack | ||
# if close parens, check if stack has this match. If yes, pop off match in stack | ||
# if at end, stack is empty, it is balanced. If parens remains, it is not balanced | ||
|
||
if string.length % 2 == 1 | ||
return false | ||
end | ||
|
||
stack = Stack.new | ||
|
||
string.each_char do |char| | ||
if char == '(' | ||
stack.push '(' | ||
elsif char == ')' && stack.pop != '(' | ||
return false | ||
end | ||
|
||
if char == '{' | ||
stack.push '}' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Close brace? |
||
elsif char == '}' && stack.pop != '{' | ||
return false | ||
end | ||
|
||
if char == '[' | ||
stack.push '[' | ||
elsif char == ']' && stack.pop != '[' | ||
return false | ||
end | ||
end | ||
return true | ||
end | ||
|
||
# Time Complexity: ? | ||
# Space Complexity: ? | ||
def evaluate_postfix(postfix_expression) | ||
raise NotImplementedError, "Not implemented yet" | ||
end | ||
# def evaluate_postfix(postfix_expression) | ||
# raise NotImplementedError, "Not implemented yet" | ||
# end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,17 @@ | ||
require 'linked_list.rb' | ||
|
||
class Queue | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With the Queue you were supposed to use a circular buffer. So this works, but it's not the assignment. |
||
|
||
def initialize | ||
# @store = ... | ||
raise NotImplementedError, "Not yet implemented" | ||
@store = LinkedList.new | ||
end | ||
|
||
def enqueue(element) | ||
raise NotImplementedError, "Not yet implemented" | ||
@store.add_last(element) | ||
end | ||
|
||
def dequeue | ||
raise NotImplementedError, "Not yet implemented" | ||
return @store.remove_first | ||
end | ||
|
||
def front | ||
|
@@ -22,7 +23,7 @@ def size | |
end | ||
|
||
def empty? | ||
raise NotImplementedError, "Not yet implemented" | ||
return @store.empty? | ||
end | ||
|
||
def to_s | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the right idea here with one typo. See below.
Do consider using a hash, it could make the code more compact.