Skip to content

Tiffany C. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tiffany C. #23

wants to merge 1 commit into from

Conversation

TiffanyChio
Copy link

Linked List Comprehension Questions

Question Response
1. What advantages does a LinkedList have over an Array? Constant space complexity when adding or removing nodes/elements.
2. When is an Array more advantageous? When getting information about a node other than the first one.
3. When is an Array more advantageous? Please see above.

CheezItMan
CheezItMan reviewed Dec 18, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! You hit the learning goals here. You do have a small bug in the final method, but otherwise well done.

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(1)
# Space complexity - O(1)
def add_first(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(1)
# Space complexity - O(1)
def get_first
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(n), where n is the length of the linked list
# Space complexity - O(1)
def length
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(n), where n is the length of the linked list
# Space complexity - O(1)
def add_last(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
def get_last

if @head == nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

lib/linked_list.rb
# Space complexity - ?

# Time complexity - O(n), where n is the length of the linked list
# Space complexity - O(1)
def get_last
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
i = 0
current = @head

while current != nil && i <= index
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if index is greater than the length of the list... small 🐛 here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiffanyChio @CheezItMan