Skip to content

Branches, C. Gutierrez #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 88 additions & 26 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,44 +2,106 @@

class LinkedList
attr_reader :head

def initialize
@head = nil
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def add_first(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Could also be done as:

head = Node.new(data, head)


temp = Node.new(data)
temp.next = @head
@head = temp
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


if @head == nil
return nil
end

return @head.data
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0
if @head == nil
return 0
end

length = 1
current = @head

while current.next != nil
length += 1
current = current.next
end
return length
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def add_last(data)


temp = Node.new(data)
current = @head

if @head == nil
@head = temp
return
elsif current.next == nil
current.next = temp
return
else
current = self.last_node
current.next = temp
Comment on lines +55 to +60

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a little overly complicated. Can you think of a way to simplify this a bit?

end
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def get_last


current = @head

if @head == nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

return nil
end
current = self.last_node
return current.data

end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def get_at_index(index)


current = @head

if index >= self.length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

return nil
end

count = 0

until count == index
count += 1
current = current.next
end

return current.data

end

def last_node
current = @head
while current.next != nil
current = current.next
end
return current
end
end

end
56 changes: 28 additions & 28 deletions test/linked_list_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,50 +12,50 @@
before do
@list = LinkedList.new
end

describe 'initialize' do
it 'can be created' do

# Assert
expect(@list).must_be_kind_of LinkedList
end
end

xdescribe 'add_first & get_first' do
describe 'add_first & get_first' do
it 'can add values to an empty list' do
# Act
@list.add_first(3)

# Assert
expect(@list.get_first).must_equal 3
@list.add_first(3)
# Assert
expect(@list.get_first).must_equal 3
end

it 'will put the last added item to the front of the list' do
# Act
@list.add_first(1)
@list.add_first(2)

# Assert
expect(@list.get_first).must_equal 2

# Act again
@list.add_first(3)

# Assert
expect(@list.get_first).must_equal 3
end

it 'will return `nil` for `getFirst` if the list is empty' do

expect(@list.get_first).must_be_nil
end
end

xdescribe "length" do
describe "length" do
it "will return 0 for an empty list" do
expect(@list.length).must_equal 0
end

it "will return the length for nonempty lists" do
count = 0
while count < 5
Expand All @@ -65,43 +65,43 @@
end
end
end

xdescribe "addLast & getLast" do
describe "addLast & getLast" do
it "will add to the front if the list is empty" do
@list.add_last(1)
expect(@list.get_first).must_equal 1
end

it "will put new items to the rear of the list" do
@list.add_last(2)
expect(@list.length).must_equal 1
expect(@list.get_last).must_equal 2

@list.add_last(3)
expect(@list.get_first).must_equal 2
expect(@list.get_last).must_equal 3
expect(@list.length).must_equal 2

@list.add_last(4)
expect(@list.get_first).must_equal 2
expect(@list.get_last).must_equal 4
expect(@list.length).must_equal 3

end

end

xdescribe 'get_at_index' do
describe 'get_at_index' do
it 'returns nil if the index is outside the bounds of the list' do
expect(@list.get_at_index(3)).must_be_nil
end

it 'can retrieve an item at an index in the list' do
@list.add_first(1)
@list.add_first(2)
@list.add_first(3)
@list.add_first(4)

expect(@list.get_at_index(0)).must_equal 4
expect(@list.get_at_index(1)).must_equal 3
expect(@list.get_at_index(2)).must_equal 2
Expand Down