Skip to content

Leaves -- Janice #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
346 changes: 235 additions & 111 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class Node
attr_reader :data # allow external entities to read value but not write
attr_accessor :next # allow external entities to read or write next node

def initialize(value, next_node = nil)
@data = value
@next = next_node
Expand All @@ -12,120 +12,244 @@ def initialize(value, next_node = nil)

# Defines the singly linked list
class LinkedList
def initialize
@head = nil # keep the head private. Not accessible outside this class
end

# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
def add_first(value)
raise NotImplementedError
end

# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
def search(value)
raise NotImplementedError
end

# method to return the max value in the linked list
# returns the data value and not the node
def find_max
raise NotImplementedError
end

# method to return the min value in the linked list
# returns the data value and not the node
def find_min
raise NotImplementedError
end


# method that returns the length of the singly linked list
def length
raise NotImplementedError
end

# method that returns the value at a given index in the linked list
# index count starts at 0
# returns nil if there are fewer nodes in the linked list than the index value
def get_at_index(index)
raise NotImplementedError
end

# method to print all the values in the linked list
def visit
raise NotImplementedError
end

# method to delete the first node found with specified value
def delete(value)
raise NotImplementedError
end

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
def reverse
raise NotImplementedError
end


## Advanced Exercises
# returns the value at the middle element in the singly linked list
def find_middle_value
raise NotImplementedError
end

# find the nth node from the end and return its value
# assume indexing starts at 0 while counting to n
def find_nth_from_end(n)
raise NotImplementedError
end

# checks if the linked list has a cycle. A cycle exists if any node in the
# linked list links to a node already visited.
# returns true if a cycle is found, false otherwise.
def has_cycle
raise NotImplementedError
end


# Additional Exercises
# returns the value in the first node
# returns nil if the list is empty
def get_first
raise NotImplementedError
def initialize
@head = nil # keep the head private. Not accessible outside this class
end

# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
def add_first(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@head = Node.new(value, @head)
end

# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
def search(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return false if @head.nil?
current = @head
until current.nil?
return true if current.data == value
current = current.next
end
return false
end

# method to return the max value in the linked list
# returns the data value and not the node
def find_max

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return nil if @head.nil?
current = @head
max = current.data
until current.nil?
max = current.data if current.data > max
current = current.next
end
return max
end

# method to return the min value in the linked list
# returns the data value and not the node
def find_min

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return nil if @head.nil?
current = @head
min = current.data
until current.nil?
min = current.data if current.data < min
current = current.next
end
return min
end


# method that returns the length of the singly linked list
def length

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0 if @head.nil?
current = @head
length = 0
until current.nil?
length += 1
current = current.next
end
return length
end

# method that returns the value at a given index in the linked list
# index count starts at 0
# returns nil if there are fewer nodes in the linked list than the index value
def get_at_index(index)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current = @head
counter = 0
until counter == index
return nil if current.nil?
counter += 1
current = current.next
end
return current.data
end

# method to print all the values in the linked list
def visit
current = @head
until current.nil?
puts current.data
length += 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

length?

current = current.next
end

# method that inserts a given value as a new last node in the linked list
def add_last(value)
raise NotImplementedError
end

# method to delete the first node found with specified value
def delete(value)
return if @head.nil?
return nil if @head.next.nil? && @head.data == value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the list has 1 element and that's the value.

Suggested change
return nil if @head.next.nil? && @head.data == value
return nil if @head.next.nil? && @head.data != value

current = @head
if current.data == value
@head = current.next
return
end
until current.nil?
if current.next.data == value
current.next = current.next.next
return
end
current = current.next
end

# method that returns the value of the last node in the linked list
# returns nil if the linked list is empty
def get_last
raise NotImplementedError
end

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
def reverse

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return if @head.nil?
current = @head
previous = nil
until current.next.nil?
temp = current.next
current.next = previous
previous = current
current = temp
end
current.next = previous
@head = current
end

## Advanced Exercises
# returns the value at the middle element in the singly linked list
def find_middle_value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return nil if @head.nil?
return @head.data if @head.next.nil?
slow = @head
fast = @head.next
until fast.nil?
slow = slow.next
fast = fast.next
if !fast.nil?
fast = fast.next
end
end

# method to insert a new node with specific data value, assuming the linked
# list is sorted in ascending order
def insert_ascending(value)
raise NotImplementedError
return slow.data
end

# find the nth node from the end and return its value
# assume indexing starts at 0 while counting to n
def find_nth_from_end(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return nil if @head.nil?
current = @head
n_ahead = @head
n.times do
n_ahead = n_ahead.next
return nil if n_ahead.nil?
end
until n_ahead.next.nil?
current = current.next
n_ahead = n_ahead.next
end
return current.data
end

# checks if the linked list has a cycle. A cycle exists if any node in the
# linked list links to a node already visited.
# returns true if a cycle is found, false otherwise.
def has_cycle

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return false if @head.nil? || @head.next.nil?
fast = @head
slow = @head
until fast.nil?
fast = fast.next
return true if slow == fast
if !fast.nil?
fast = fast.next
return true if slow == fast
end
slow = slow.next
end

# Helper method for tests
# Creates a cycle in the linked list for testing purposes
# Assumes the linked list has at least one node
def create_cycle
return if @head == nil # don't do anything if the linked list is empty

# navigate to last node
current = @head
while current.next != nil
current = current.next
return false
end

# Additional Exercises
# returns the value in the first node
# returns nil if the list is empty
def get_first
return nil if @head.nil?
return @head.data
end

# method that inserts a given value as a new last node in the linked list
def add_last(value)
if @head.nil?
add_first(value)
return
end
current = @head
until current.next.nil?
current = current.next
end
inserted = Node.new(value, nil)
current.next = inserted
end

# method that returns the value of the last node in the linked list
# returns nil if the linked list is empty
def get_last

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return nil if @head.nil?
current = @head
until current.next.nil?
current = current.next
end
return current.data
end

# method to insert a new node with specific data value, assuming the linked
# list is sorted in ascending order
def insert_ascending(value)
return if @head.nil?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the list is empty, shouldn't the inserted element go to the front?

current = @head
if current.data >= data
add_first(value)
return
end
until current.next.nil?
if current.data <= data && current.next.data >= data
insertion = Node.new(value, current.next)
current.next = insertion
return
end

current.next = @head # make the last node link to first node
current = current.next
end
insertion = Node.new(value, nil)
current.next = insertion
end

# Helper method for tests
# Creates a cycle in the linked list for testing purposes
# Assumes the linked list has at least one node
def create_cycle
return if @head == nil # don't do anything if the linked list is empty

# navigate to last node
current = @head
while current.next != nil
current = current.next
end

current.next = @head # make the last node link to first node
end
end