Skip to content

Branches, Kristy #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Branches, Kristy #50

wants to merge 2 commits into from

Conversation

kristyh32
Copy link

JS Adagrams

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Most of the same patterns that were used in Ruby are still available in JavaScript, like iterating over arrays and if else logic.
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? A little bit? There is a lot more JavaScript info out there that is really outdated compared to Ruby, so you have to weed through things a bit more.
What was a challenge you were able to overcome on this assignment? figuring out how to create an object.
What has been interesting and positive about learning a new programming language? It's been much easier to pick up the second language because I still have all the logic knowledge from the first language.
What is something to focus on your learnings in JavaScript in the next week? More about objects and how to use them better.

@jmaddox19
Copy link

JS Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions x
Small commits with meaningful commit messages Looks like you forgot to make incremental commits while you were working.
Code Requirements
drawLetters method x
Uses appropriate data structure to store the letter distribution It would be more readable and error-proof to keep up with the quantity of a letter with a number but this obviously works too.
All tests for drawLetters pass x
usesAvailableLetters method x
All tests for usesAvailableLetters pass x
scoreWord method x
Uses appropriate data structure to store the letter scores What is there is technically not a data structure but works great in my opinion.
All tests for scoreWord pass x
Optional
highestScoreFrom method x
Appropriately handles edge cases for tie-breaking logic x
All tests for highestScoreFrom pass x
Overall Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants