Skip to content

Branches - Erika #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Branches - Erika #32

wants to merge 11 commits into from

Conversation

emaust
Copy link

@emaust emaust commented Nov 17, 2019

JS Adagrams

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Primarily recognizing that I should create key value pairs to store letter information in and when/what loops to use.
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? I found it much easier to google what I syntax I wanted compared to when I was learning the same in Ruby, but that was almost entirely because I've learned what function/method I'm looking for and what it's probably called. I did have to adjust some phrasing to avoid getting html/css related hits.
What was a challenge you were able to overcome on this assignment? I got stuck trying to do a switch statement on Wave 3 and couldn't figure out why it wouldn't return the point value. When I read the documentation more carefully I was able to see that I wasn't using it correctly and it actually wasn't something I truly needed to use.
What has been interesting and positive about learning a new programming language? Now that I have a basic understanding of how things work with the more generic parts of programming languages, I enjoyed having the time/ability to more easily find different functions and syntax and chose the one I liked the most instead of trying to force my code into the only one I understood.
What is something to focus on your learnings in JavaScript in the next week? I can definitely get better at using (or just actually use) arrow functions and dry up my code.

@CheezItMan
Copy link

JS Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions Check, glad you learned quite a bit
Small commits with meaningful commit messages Check, good granular commits and meaningful commit messages
Code Requirements
drawLetters method Check
Uses appropriate data structure to store the letter distribution Check
All tests for drawLetters pass Check
usesAvailableLetters method Check
All tests for usesAvailableLetters pass Check
scoreWord method Check
Uses appropriate data structure to store the letter scores Check
All tests for scoreWord pass Check
Overall Nice work, you hit the learning goals here. Well done.



// Use Fisher-Yates/Knuth Shuffle
shuffler(array) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice helper! With good documentation!

}
return array;
},

drawLetters() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return false;
} else {
let index = lettersInHand.indexOf(element);
lettersInHand.splice(index, 1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One problem here is that letters in hand will be mutated here. That could lead to side-effects if someone 's anticipating that the original array isn't modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants