-
Notifications
You must be signed in to change notification settings - Fork 50
Branches - Erika #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Branches - Erika #32
Conversation
…drawLetters function to include splice within it. Wave 1 tests passing
…d letters. Does not check for duplicates or length errors
…duplicates. Tests passing.
…scoring, conditionals for length. Correctly scores items but still case sensitive. Passing 3/4 wave 3 tests.
JS AdagramsWhat We're Looking For
|
|
||
|
||
// Use Fisher-Yates/Knuth Shuffle | ||
shuffler(array) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice helper! With good documentation!
} | ||
return array; | ||
}, | ||
|
||
drawLetters() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
return false; | ||
} else { | ||
let index = lettersInHand.indexOf(element); | ||
lettersInHand.splice(index, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One problem here is that letters in hand will be mutated here. That could lead to side-effects if someone 's anticipating that the original array isn't modified.
JS Adagrams
Congratulations! You're submitting your assignment!
Comprehension Questions