-
Notifications
You must be signed in to change notification settings - Fork 50
Leaves - Samantha #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -1,8 +1,68 @@ | |||
const Adagrams = { | |||
drawLetters() { | |||
// Implement this method for wave 1 | |||
const alphabet = 'AAAAAAAAABBCCDDDDEEEEEEEEEEEEFFGGGHHIJKLLLLMMNNNNNNOOOOOOOOPPQRRRRRRSSSSTTTTTTUUUUVVWWXYYZ'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This data structure works, but it's not very DRY and would be tricky to change. For example, suppose I said you had the wrong number of "I"s - you would have to do a lot of counting to solve the problem.
Instead you might store a hash of letter frequencies like this
letterQuantities: {
A: 9, B: 2, ...
}
const alphabet = 'AAAAAAAAABBCCDDDDEEEEEEEEEEEEFFGGGHHIJKLLLLMMNNNNNNOOOOOOOOPPQRRRRRRSSSSTTTTTTUUUUVVWWXYYZ'; | ||
const lettersInHand = []; | ||
|
||
for (let i = 0; i < 10; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small bug here. Consider how you could make sure you don't pick the same letter 10 times (however unlikely it is).
|
||
for (let i = 0; i < (input.length); i++) { | ||
if (lettersInHand.includes(input[i]) === false) { | ||
result = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you used a traditional for loop you could simply return false
here so you don't unnecessarily need to go through the whole loop.
}, | ||
|
||
scoreWord(word) { | ||
const score = { A:1, E:1, I:1, O:1, U:1, L:1, N:1, R:1, S:1, T:1, D:2, G:2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style note: put each key-value pair on one line.
// The function indexOf finds the value for the index with the max value | ||
let correct = { word: words[scores.indexOf(Math.max.apply(null, scores))], score: Math.max.apply(null, scores) }; | ||
|
||
// Still need to work on the tie-breaking rules for Wave 4: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got a good start!
JS AdagramsWhat We're Looking For
|
JS Adagrams
Congratulations! You're submitting your assignment!
Comprehension Questions