Skip to content

Leaves_Ga-Young #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions lib/practice_exercises.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,34 @@

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n) where n is the sorted array
# Space Complexity: O(1)
def remove_duplicates(list)
raise NotImplementedError, "Not implemented yet"
counter = 0
list.length.times do |num|
if list[counter] == list[counter + 1]
list.delete_at(counter + 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since delete_at shifts all subsequent element left one index, it has a runtime of O(n). Using in your loop here gives you a method time complexity of O(n2)

else
counter += 1
end
end
return list
end

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n) where n is the strings array

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the strings are small yes, otherwise you can say O(n * m) where m is the min length of the strings.

# Space Complexity: O(1)
def longest_prefix(strings)
raise NotImplementedError, "Not implemented yet"
longest_prefix = strings[0]
strings.each do |string|
letter_counter = 0
longest_prefix.length.times do
if longest_prefix[letter_counter] == string[letter_counter]
letter_counter += 1
else
longest_prefix = longest_prefix.slice(0, letter_counter)
break
end
end
end
return longest_prefix
end


31 changes: 20 additions & 11 deletions test/practice_exercises_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,34 +9,43 @@
it "works for empty arrays" do
expect(remove_duplicates([])).must_equal []
end

it "will remove duplicates for longer arrays" do
expect(remove_duplicates([1, 2, 2, 3, 3, 4])).must_equal [1, 2, 3, 4]
expect(remove_duplicates([1, 2, 2, 3, 3, 4]).reject{|num| num == nil }).must_equal [1, 2, 3, 4]
end
end

describe "Longest valid substring" do
it "will work for the README strings" do
strings = ["flower","flow","flight"]

output = longest_prefix(strings)

expect(output).must_equal "fl"
end


it "will work for the strings that are the same" do
strings = ["flower","flower","flower"]

output = longest_prefix(strings)

expect(output).must_equal "flower"
end

it "will work for the strings with the common prefix in the rear" do
strings = ["flower","flow","flight", "fpastafl"]

output = longest_prefix(strings)

expect(output).must_equal "f"
end



it "will work for the README strings" do
strings = ["dog","racecar","car"]

output = longest_prefix(strings)

expect(output).must_equal ""
end
end
Expand Down