Pr-1 #1
Open
Pr-1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norrise120
reviewed
Aug 15, 2019
| const calculateAverage = function calculateAverage(grades) { | ||
|
|
||
| let total = 0; | ||
| for (let i = 0; i < grades.length; i++) { |
There was a problem hiding this comment.
What happens if grades is null? Does a statement need to be added for this edge case?
| total += grades[i]; | ||
| } | ||
|
|
||
| let avg = total / grades.length; |
There was a problem hiding this comment.
What should be returned if there are no grades? I think you would get undefined here if grades is an empty array.
laneia
reviewed
Aug 15, 2019
| @@ -0,0 +1,14 @@ | |||
|
|
|||
| const calculateAverage = function calculateAverage(grades) { | |||
There was a problem hiding this comment.
Consider refactoring into an arrow function
jillirami
reviewed
Aug 15, 2019
| @@ -0,0 +1,14 @@ | |||
|
|
|||
| const calculateAverage = function calculateAverage(grades) { | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| if (grades == null || grades == undefined) { | |
| return "No Grades Provided"; | |
| } |
bonara
reviewed
Aug 15, 2019
| @@ -0,0 +1,14 @@ | |||
|
|
|||
| const calculateAverage = function calculateAverage(grades) { | ||
|
|
||
| let total = 0; | ||
| for (let i = 0; i < grades.length; i++) { |
There was a problem hiding this comment.
forEach loop might be better for an array
| let avg = total / grades.length; | ||
|
|
||
| return avg; | ||
| }; |
sjscotton
reviewed
Aug 15, 2019
| const calculateAverage = function calculateAverage(grades) { | ||
|
|
||
| let total = 0; | ||
| for (let i = 0; i < grades.length; i++) { |
There was a problem hiding this comment.
Maybe consider using a for of loop:
for (grade of grades) {
}
| total += grades[i]; | ||
| } | ||
|
|
||
| let avg = total / grades.length; |
There was a problem hiding this comment.
Suggested change
| let avg = total / grades.length; | |
| const avg = total / grades.length; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method will calculate the average of an array of grades.