Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Heather, Jillianne, Myriam, Ngoc #77

Open
wants to merge 339 commits into
base: master
Choose a base branch
from

Conversation

jillirami
Copy link

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question Answer
Each team member: what is one thing you were primarily responsible for that you're proud of? (Heather) Order Controller, (Jillianne) Orderitem Controller, (Myriam) Merchant Dashboard Filters, (Ngoc) Product Controller.
Each team member: what is one thing you were primarily responsible for that you would like targeted feedback on? (Heather) Order controller tests as it relates to order items, (Jillianne) Order item controller tests, (Myriam) Merchant model business logic, (Ngoc) Review create action method.
How did your team break up the work to be done? We broke up work initially based on controller and model groupings, then proceeded to assign work based on individual availability when previous tasks complete.
How did your team utilize git to collaborate? We utilized git at all times to maintain record of individual work, and merge in pull requests to our master branch when necessary.
What did your group do to try to keep your code DRY while many people collaborated on it? We utilized partial views/forms and test/method helpers to DRY code. We also produced code that was functional first, then attempted to DRY code at any opportunity we found.
What was a technical challenge that you faced as a group? Intertwining logic that team members worked on independently was difficult, but we worked patiently and steadily to fix it.
What was a team/personal challenge that you faced as a group? Git pull requests and merging was a team challenge and we learned and achieved a lot by working together.
What was your application's ERD? (include a link) https://www.lucidchart.com/documents/view/3be8589a-64e4-4b39-a51a-3f1fc0580e96/0
What is your Trello URL? https://trello.com/b/MuwdtzrQ/grey-matter-team
What is the Heroku URL of your deployed application? https://tipsytime.herokuapp.com/

MyriamWD and others added 30 commits May 3, 2019 15:49
Nl products new create - remove development log file
MW -> test for merchant auth, application header navigation bar, and flash messages section
…e products_controller new and create method to require login, changed error_form back to field, updated controller test to have require login
jillirami and others added 30 commits May 10, 2019 13:29
fix bug in the review controller to allow log in merchant to review o…
display flash messages - fixed begin hehe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants