Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Jillianne #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ports - Jillianne #45

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
034a25f
Completed method structure
jillirami Feb 21, 2019
281dbb5
complete assignment
jillirami Mar 2, 2019
94d9455
refactored solution
jillirami May 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order
def array_equals(array1, array2)
raise NotImplementedError

def array_equals(array_a, array_b)
if (array_a == [] && array_b == [] || array_a == nil && array_b == nil)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow! I like how you used a compound conditional to group all the true and false edge cases together. VERY NICE. ✨✨✨

return true
elsif array_a == nil || array_b == nil || array_a.length != array_b.length
return false
else
array_a.length.times do |item|
if array_b[item] != array_a[item]
return false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It returns false as soon as it finds two chars that don't match. Brilliant! Have a 🍬

end
end
return true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AND..... SHE STICKS THE LANDING! Returns true if all chars match. Perf. 🔥

end
end