Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Shubha #36

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Sockets - Shubha #36

wants to merge 10 commits into from

Conversation

shubha-rajan
Copy link

MediaRanker Revisited

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What did you need to configure and setup to make OAuth installed and work? I needed to create an application on github, set up omniauth, set up dotenv, and add the client_id and client_secret to the .env file
What areas of Rails app code did you need to create/write/modify in order to change logging in to use OAuth? We had to change routes, controller methods for user, the login/logout links in views, and the user model.
What was one controller test you updated? Why did you need to update it? I updated the controller tests for the destroy method to make sure only an authenticated user who is associated with a work can delete it.
Why did we need to mock OAuth for testing? To eliminate the dependency on the oauth provider in testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant