Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Erica #31

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Sockets - Erica #31

wants to merge 11 commits into from

Conversation

norrise120
Copy link

MediaRanker Revisited

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What did you need to configure and setup to make OAuth installed and work? I needed to configure the OmniAuth gem in the application and the OAuth app on Github. I also needed to create a .env file with my secret token and configure rails to read that file.
What areas of Rails app code did you need to create/write/modify in order to change logging in to use OAuth? I modified the gemfile, the routes, the user model and controller, and the view.
What was one controller test you updated? Why did you need to update it? I updated the tests for the works#index page. Before, anyone could see the works index page. This needed to be updated to make sure that logged in users could access the page, but that the non logged in users would be redirected to the root path.
Why did we need to mock OAuth for testing? We mock OAuth for testing to remove the dependency on Github. If we used OAuth for our testing, we would depend on Github for every log in that we require in our tests. This could cause failures in our test if Github is down, even if our code is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant