Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports - Sav #29

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

ports - Sav #29

wants to merge 17 commits into from

Conversation

qqdipps
Copy link

@qqdipps qqdipps commented May 14, 2019

MediaRanker Revisited

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What did you need to configure and setup to make OAuth installed and work? To get OAuth to work I added: 'omniauth', 'omniauth-github', 'dotenv-rails' gems to gemfile. Then I set up the .env file with my github secrets. I also had to create a file, config/initializers/omniauth.rb to config github has provider and name of keys. Also, set up routes.
What areas of Rails app code did you need to create/write/modify in order to change logging in to use OAuth? gemfile, config/initializers/ominauth.rb, .env, routes.rb, user.rb, users_controller.rb
What was one controller test you updated? Why did you need to update it? I updated the work index controller test. I had to update it because all the tests were failing because I had updated the works#index action to req user to be logged in.
Why did we need to mock OAuth for testing? To eleminate third party dependency during testing. Their service could be running slow or down which would cause tests to be slow or fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant