Ports - Myriam

[MyriamWD]

MediaRanker Revisited

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What did you need to configure and setup to make OAuth installed and work?	Make sure I had OmniAuth gem, .env file with secrets, and .env added to gitignore. Create initializer omniauth file. Add route for login and callback. Add create action to the users controller and implement auth_hash. Generate new migrations to add name, email, uid, provider columns to user table. Run migrations. Add build from GitHub method to the model, implement it in the create action in users controller. Add logout route. Add destroy action to users controller. Make sure to implement the paths on the view for the login and logout button.
What areas of Rails app code did you need to create/write/modify in order to change logging in to use OAuth?	Routes, schema, user model, user controller (previous login implemented), and tests.
What was one controller test you updated? Why did you need to update it?	edit in works controller. Login is required to execute that action after implementing authorization. I had to use the test helper perform login action to make it work.
Why did we need to mock OAuth for testing?	To eliminate dependencies in testing and be able to tests even when there is not network connection.

[CheezItMan]

MediaRanker Revisted

What We're Looking For

Feature	Feedback
General
Completed OAuth	Check
Appropriate Tests on WorksController	Missing Tests for guest users
Appropriate Tests on UsersController	Check
Basic Authorization (who can see what)	Check, plus bonus work, nice controller filters
Overall	Not bad, you hit all the learning goals, except writing tests for guest users in the WorksController. That's a pretty big thing to miss. I suggest scheduling a bit of time each day to review your code and look for missing tests, a coverage report would have revealed that your checks for guest users weren't being tested.

[CheezItMan]

One problem with these tests is that you don't have a set of tests for guest users. So you don't have tests that assure that guest users can't do specific things like view a show page, or delete a work.

[CheezItMan]

👍

[CheezItMan]

👍

[CheezItMan]

👍