Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installers should not default to non-interactive. #3617

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Installers should not default to non-interactive. #3617

merged 2 commits into from
Dec 19, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Dec 18, 2024 •
edited by github-actions bot
Loading

BugDX-3193 Windows ST install fail if install as Administrator

DX-3193 actually uncovered two problems:

  1. --non-interactive was overriding --force (fixed in Force prompt option should override non-interactive option. #3616 )
  2. Installers were running in non-interactive mode by default (fixed here). Our automated tests didn't catch this case since they are always running in non-interactive mode. Only manual QA revealed it.

@mitchell-as mitchell-as marked this pull request as ready for review December 18, 2024 23:01
@mitchell-as mitchell-as merged commit 7eaa7e1 into version/0-48-0-RC1 Dec 19, 2024
10 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-3193-2 branch December 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjsanterre tjsanterre tjsanterre approved these changes

Assignees
No one assigned
Labels
Test: install-scripts Test: installer Test: remote-installer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @tjsanterre