Fixed test failure. #3522
Fixed test failure. #3522
Conversation
mitchell-as
force-pushed
the
mitchelll/dx-3097
branch
4 times, most recently
from
ff69c6e to
49ca52a
Compare
The solver is getting faster!
mitchell-as
force-pushed
the
mitchelll/dx-3097
branch
from
49ca52a to
bcd3f82
Compare
| cp.Expect("Resolving Dependencies") | ||
| cp.ExpectRe(`[^.]+?✔ Done`, e2e.RuntimeSolvingTimeoutOpt) |
There was a problem hiding this comment.
This first checkout seems to specifically be about asserting that it does NOT use dot progress, but these changes seem to make it so that it is asserting that it DOES use dot progress.
There was a problem hiding this comment.
This test is expecting that there are no dots between "Resolving Dependencies" and "✔ Done", so it's asserting that it does NOT use dot progress.
I had to do a few iterations of this test, and during these iterations I found that cp.Output() gave me all the escape sequences of the \, |, and / interactive progress between "Resolving Dependencies" and "✔ Done". I am confident this test is working as intended.
There was a problem hiding this comment.
Ahh.. the way the regex is written I had assumed it was checking for ... ✔ Done. I had interpreted the dot as a literal dot rather than a regex rule. Might be worth adding a comment for clarity.
The solver is getting faster!